From patchwork Tue Jan 22 00:09:50 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Theodore Ts'o X-Patchwork-Id: 214298 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id CC0432C0040 for ; Tue, 22 Jan 2013 11:10:38 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751765Ab3AVAJ5 (ORCPT ); Mon, 21 Jan 2013 19:09:57 -0500 Received: from li9-11.members.linode.com ([67.18.176.11]:44698 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751541Ab3AVAJ4 (ORCPT ); Mon, 21 Jan 2013 19:09:56 -0500 Received: from root (helo=closure.thunk.org) by imap.thunk.org with local-esmtp (Exim 4.80) (envelope-from ) id 1TxRR1-0004yi-9g; Tue, 22 Jan 2013 00:09:51 +0000 Received: by closure.thunk.org (Postfix, from userid 15806) id 1AF6230A577; Mon, 21 Jan 2013 19:09:50 -0500 (EST) From: Theodore Ts'o To: Ext4 Developers List Cc: Theodore Ts'o Subject: [PATCH 3/3] contrib: fix namespace leakage in spd_readdir Date: Mon, 21 Jan 2013 19:09:50 -0500 Message-Id: <1358813390-26466-3-git-send-email-tytso@mit.edu> X-Mailer: git-send-email 1.7.12.rc0.22.gcdd159b In-Reply-To: <1358813390-26466-1-git-send-email-tytso@mit.edu> References: <1358813390-26466-1-git-send-email-tytso@mit.edu> X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Declare the internal symbols alloc_dirstruct() and cache_dirstruct() as static so they don't leak out into the global namespace. Signed-off-by: "Theodore Ts'o" --- contrib/spd_readdir.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/spd_readdir.c b/contrib/spd_readdir.c index 910b104..8345fa1 100644 --- a/contrib/spd_readdir.c +++ b/contrib/spd_readdir.c @@ -186,7 +186,7 @@ static int ino_cmp(const void *a, const void *b) return (i_a - i_b); } -struct dir_s *alloc_dirstruct(DIR *dir) +static struct dir_s *alloc_dirstruct(DIR *dir) { struct dir_s *dirstruct; static pthread_mutexattr_t mutexattr; @@ -200,7 +200,7 @@ struct dir_s *alloc_dirstruct(DIR *dir) return dirstruct; } -void cache_dirstruct(struct dir_s *dirstruct) +static void cache_dirstruct(struct dir_s *dirstruct) { struct dirent_s *ds, *dnew; struct dirent64 *d;