Patchwork [1/5] target-i386: print deprecated warning if xlevel < 0x80000000

login
register
mail settings
Submitter Igor Mammedov
Date Jan. 21, 2013, 2:06 p.m.
Message ID <1358777199-5735-2-git-send-email-imammedo@redhat.com>
Download mbox | patch
Permalink /patch/214174/
State New
Headers show

Comments

Igor Mammedov - Jan. 21, 2013, 2:06 p.m.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
---
  Amend warning message as suggested by Andreas s/depricated/removed/
---
 target-i386/cpu.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Andreas Färber - Jan. 21, 2013, 2:56 p.m.
Am 21.01.2013 15:06, schrieb Igor Mammedov:
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>   Amend warning message as suggested by Andreas s/depricated/removed/

Thanks, applied to qom-cpu queue:
https://github.com/afaerber/qemu-cpu/commits/qom-cpu

Andreas

> ---
>  target-i386/cpu.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index d1a14d5..f0f3df1 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -1394,6 +1394,8 @@ static int cpu_x86_parse_featurestr(x86_def_t *x86_cpu_def, char *features)
>                      goto error;
>                  }
>                  if (numvalue < 0x80000000) {
> +                    fprintf(stderr, "xlevel value shall always be >= 0x80000000"
> +                            ", fixup will be removed in future versions\n");
>                      numvalue += 0x80000000;
>                  }
>                  x86_cpu_def->xlevel = numvalue;

Patch

diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index d1a14d5..f0f3df1 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1394,6 +1394,8 @@  static int cpu_x86_parse_featurestr(x86_def_t *x86_cpu_def, char *features)
                     goto error;
                 }
                 if (numvalue < 0x80000000) {
+                    fprintf(stderr, "xlevel value shall always be >= 0x80000000"
+                            ", fixup will be removed in future versions\n");
                     numvalue += 0x80000000;
                 }
                 x86_cpu_def->xlevel = numvalue;