From patchwork Mon Jan 21 11:43:53 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amar X-Patchwork-Id: 214099 X-Patchwork-Delegate: promsoft@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 815B02C0084 for ; Mon, 21 Jan 2013 22:27:47 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 7AE1B4A10C; Mon, 21 Jan 2013 12:27:45 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TadgSYgL0I1R; Mon, 21 Jan 2013 12:27:45 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id BED5C4A0F9; Mon, 21 Jan 2013 12:27:42 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 8B9B64A0F9 for ; Mon, 21 Jan 2013 12:27:40 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UD0uJ9dRbg1e for ; Mon, 21 Jan 2013 12:27:27 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) by theia.denx.de (Postfix) with ESMTP id 5188D4A053 for ; Mon, 21 Jan 2013 12:27:25 +0100 (CET) Received: from epcpsbgm2.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MGZ008763TLV610@mailout3.samsung.com> for u-boot@lists.denx.de; Mon, 21 Jan 2013 20:27:23 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [172.20.52.122]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 6B.6E.03880.A162DF05; Mon, 21 Jan 2013 20:27:23 +0900 (KST) X-AuditID: cbfee61b-b7fb06d000000f28-36-50fd261a5391 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id BA.6E.03880.A162DF05; Mon, 21 Jan 2013 20:27:22 +0900 (KST) Received: from chrome-ubuntu.sisodomain.com ([107.108.73.106]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MGZ0092C3L1A540@mmp2.samsung.com> for u-boot@lists.denx.de; Mon, 21 Jan 2013 20:27:22 +0900 (KST) From: Amar To: u-boot@lists.denx.de, jh80.chung@samsung.com Date: Mon, 21 Jan 2013 06:43:53 -0500 Message-id: <1358768638-14187-6-git-send-email-amarendra.xt@samsung.com> X-Mailer: git-send-email 1.8.0 In-reply-to: <1358768638-14187-1-git-send-email-amarendra.xt@samsung.com> References: <1358768638-14187-1-git-send-email-amarendra.xt@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMLMWRmVeSWpSXmKPExsWyRsSkSlda7W+AQft9Nou3ezvZHRg9zt7Z wRjAGMVlk5Kak1mWWqRvl8CV0X9jDmPBGb6Kk4vPMzcwXufuYuTkkBAwkejc9Z8NwhaTuHBv PZDNxSEksJRRov/ebmaYom2ftrFDJKYzSrRvmsAM4Sxjkvj0dQVQhoODTUBV4tdie5AGEQED ielPtrOC2MwCNRKT599iArGFBVIkmj9PBouzAJV3rJ0NFucV8JC4cHo2K8QyOYkPex6xg9ic Ap4S+//uAYsLAdXsWvCfFWSvhMBlNok1KyewQwwSkPg2+RALyA0SArISmw5AHS0pcXDFDZYJ jMILGBlWMYqmFiQXFCel5xrpFSfmFpfmpesl5+duYgQG4el/z6R3MK5qsDjEKMDBqMTDm9D3 J0CINbGsuDL3EKMEB7OSCO/PGUAh3pTEyqrUovz4otKc1OJDjMlAyycyS4km5wMjJK8k3tDY xNzU2NTSyMjM1JQ0YSVxXsZTTwKEBNITS1KzU1MLUotgtjBxcEo1MC4z2bNKUO6IWiz71v9b FA3zQyve9OSm/11jt0TvpHZCk6E706Ip9zO5QzZzcFxx8Xp+jHP6Ral9hjfVv/2d+c97gcfU 8oTlyhKXuve1d/6/qrWTlzkxNicx9bicuWzT4aLy43xcjhfPyObXnfqx3Ohc8POz/yfHOJyU fGktIcCR+uO+Tq9fkBJLcUaioRZzUXEiAOAwcV+GAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrEIsWRmVeSWpSXmKPExsVy+t9jQV0ptb8BBqv+m1u83dvJ7sDocfbO DsYAxqgGRpuM1MSU1CKF1Lzk/JTMvHRbJe/geOd4UzMDQ11DSwtzJYW8xNxUWyUXnwBdt8wc oLFKCmWJOaVAoYDE4mIlfTtME0JD3HQtYBojdH1DguB6jAzQQMIaxoz+G3MYC87wVZxcfJ65 gfE6dxcjJ4eEgInEtk/b2CFsMYkL99azdTFycQgJTGeUaN80gRnCWcYk8enrCqAqDg42AVWJ X4vtQRpEBAwkpj/ZzgpiMwvUSEyef4sJxBYWSJFo/jwZLM4CVN6xdjZYnFfAQ+LC6dmsEMvk JD7seQS2mFPAU2L/3z1gcSGgml0L/rNOYORdwMiwilE0tSC5oDgpPddIrzgxt7g0L10vOT93 EyM4xJ9J72Bc1WBxiFGAg1GJhzeh70+AEGtiWXFl7iFGCQ5mJRHenzOAQrwpiZVVqUX58UWl OanFhxiTga6ayCwlmpwPjL+8knhDYxNzU2NTSxMLEzNL0oSVxHkZTz0JEBJITyxJzU5NLUgt gtnCxMEp1cDYGSv2ulDqYMW5+8oXElOl725NC/8SM4M7UO1uRfTpCQsPLA9x+aSz+vXGOQUH bbaX7D71TDHQMLuIf4td+m7GvKsXVwr7Zr7kYP3+zql74oJlfSLVzkyn+vf9fOrfvytvp/bm B2I/Zq0SYWN1knlTbfHrycN9Mlc3CsWW2TNU8u2+F+T6xWmiEktxRqKhFnNRcSIAAQ3yfbUC AAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Cc: patches@linaro.org, afleming@gmail.com, hs@denx.de Subject: [U-Boot] [PATCH V5 05/10] EXYNOS5: DWMMC: Initialise the local variable to avoid unwanted results. X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de This patch initialises the local variable 'shift' to zero. The uninitialised local variable 'shift' had garbage value and was resulting in unwnated results in the functions exynos5_get_mmc_clk() and exynos4_get_mmc_clk(). Signed-off-by: Amar Acked-by: Simon Glass --- Changes since V1: 1)Updated the function exynos5_mmc_set_clk_div() to receive 'device_i'd as input parameter instead of 'index'. Changes since V2: 1)Updation of commit message and resubmition of proper patch set. Changes since V3: 1)Removed the new API exynos5_mmc_set_clk_div() from clock.c, because existing API set_mmc_clk() can be used to set mmc clock. Changes since V4: 1)Updated the subject line to reflect the changes present in this patch. 2)Changes of the file arch/arm/include/asm/arch-exynos/clk.h which were present in this patch, have been moved out of this patch. arch/arm/cpu/armv7/exynos/clock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/cpu/armv7/exynos/clock.c b/arch/arm/cpu/armv7/exynos/clock.c index 956427c..edce21c 100644 --- a/arch/arm/cpu/armv7/exynos/clock.c +++ b/arch/arm/cpu/armv7/exynos/clock.c @@ -490,7 +490,7 @@ static unsigned long exynos4_get_mmc_clk(int dev_index) (struct exynos4_clock *)samsung_get_base_clock(); unsigned long uclk, sclk; unsigned int sel, ratio, pre_ratio; - int shift; + int shift = 0; sel = readl(&clk->src_fsys); sel = (sel >> (dev_index << 2)) & 0xf; @@ -539,7 +539,7 @@ static unsigned long exynos5_get_mmc_clk(int dev_index) (struct exynos5_clock *)samsung_get_base_clock(); unsigned long uclk, sclk; unsigned int sel, ratio, pre_ratio; - int shift; + int shift = 0; sel = readl(&clk->src_fsys); sel = (sel >> (dev_index << 2)) & 0xf;