Patchwork [2/4] acpitable: open the data file in binary mode

login
register
mail settings
Submitter Stefan Hajnoczi
Date Jan. 21, 2013, 10:59 a.m.
Message ID <1358765983-30201-3-git-send-email-stefanha@redhat.com>
Download mbox | patch
Permalink /patch/214086/
State New
Headers show

Comments

Stefan Hajnoczi - Jan. 21, 2013, 10:59 a.m.
From: Michael Tokarev <mjt@tls.msk.ru>

-acpitable {file|data}=file reads the content of file, but it is
in binary form, so the file should be opened usin O_BINARY flag.
On *nix it is a no-op, but on windows and other weird platform
it is really needed.

Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 hw/acpi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/hw/acpi.c b/hw/acpi.c
index 97617c4..8c9dcc5 100644
--- a/hw/acpi.c
+++ b/hw/acpi.c
@@ -104,7 +104,7 @@  int acpi_table_add(const char *t)
     /* now read in the data files, reallocating buffer as needed */
 
     for (f = strtok(buf, ":"); f; f = strtok(NULL, ":")) {
-        int fd = open(f, O_RDONLY);
+        int fd = open(f, O_RDONLY | O_BINARY);
 
         if (fd < 0) {
             fprintf(stderr, "can't open file %s: %s\n", f, strerror(errno));