Patchwork [pull,request,v2] Pull request for branch yem-instrument-build

login
register
mail settings
Submitter Yann E. MORIN
Date Jan. 20, 2013, 4:03 p.m.
Message ID <cover.1358697765.git.yann.morin.1998@free.fr>
Download mbox
Permalink /patch/213956/
State Accepted
Headers show

Pull-request

git://gitorious.org/buildroot/buildroot.git yem-instrument-build

Comments

Yann E. MORIN - Jan. 20, 2013, 4:03 p.m.
Hello All!

This series adds some intrumentation to the pkg-infra so that it is easier
for the autobuilders to extract meaningfull information about the reason
of failures.

It does so by:
  - logging all messages displayed with calls to MESSAGE to a time-stamped
    log file
  - log the last such mesage to a file
  - add calls to MESSAGE in the non-package steps of the external toolchain
    backend
  - add calls to MESSAGE in the non-package steps of the crosstool-NG
    toolchain backend
  - add calls to MESSAGE in the non-package steps of the internal toolchain
    backend (gcc, kernel headers, and uClibc)

Although I've tested it with external and internal toolchain backends (not
crosstool-NG for now), and although it does work, I expect some polishing
to be required. 

So, take this series as a kind of RFC, rather than a final series.


Changes v1 -> v2:
  - invert the patches ordering for easier upstreaming (Thomas)
  - include Arnout's fixes against the filesystem infra (Arnout)
    (with a few fixes for "no newline at end of file" by me)
  - eye-candy fixes in displayed messages (Arnout)


The following changes since commit ad0279f0ee51e97bf7dbb70fdd6f14f789f344a8:

  gettext: fix static build failure (2013-01-20 09:54:25 +0100)

are available in the git repository at:
  git://gitorious.org/buildroot/buildroot.git yem-instrument-build

Yann E. MORIN (7):
      toolchain/external: sprinkle with some calls to MESSAGE
      toolchain/crosstool-ng: sprinkle with some calls to MESSAGE
      toolchain/gcc: sprinkle with some calls to MESSAGE
      toolchain/kernel-headers: sprinkle with some calls to MESSAGE
      toolchain/uClibc: sprinkle with some calls to MESSAGE
      fs/common.mk: delay evaluation of variables.
      pkg-infra: log current message

 fs/cloop/cloop.mk                                |    4 +-
 fs/common.mk                                     |   44 +++++++++++-----------
 fs/cpio/cpio.mk                                  |    2 +-
 fs/cramfs/cramfs.mk                              |    2 +-
 fs/ext2/ext2.mk                                  |    2 +-
 fs/jffs2/jffs2.mk                                |    8 ++--
 fs/romfs/romfs.mk                                |    4 +-
 fs/squashfs/squashfs.mk                          |    4 +-
 fs/tar/tar.mk                                    |    2 +-
 fs/ubifs/ubi.mk                                  |    4 +-
 fs/ubifs/ubifs.mk                                |    4 +-
 package/pkg-utils.mk                             |    9 ++++-
 toolchain/gcc/gcc-uclibc-4.x.mk                  |   16 ++++++++
 toolchain/kernel-headers/kernel-headers.mk       |    4 ++
 toolchain/toolchain-crosstool-ng/crosstool-ng.mk |    5 +-
 toolchain/toolchain-external/ext-tool.mk         |    8 ++-
 toolchain/uClibc/uclibc.mk                       |   13 ++++++
 17 files changed, 88 insertions(+), 47 deletions(-)

Regards,
Yann E. MORIN
Yann E. MORIN - Jan. 20, 2013, 4:38 p.m.
All,

On Sunday 20 January 2013 Yann E. MORIN wrote:
> This series adds some intrumentation to the pkg-infra so that it is easier
> for the autobuilders to extract meaningfull information about the reason
> of failures.
[--SNIP--]
> Yann E. MORIN (7):
>       toolchain/external: sprinkle with some calls to MESSAGE
>       toolchain/crosstool-ng: sprinkle with some calls to MESSAGE
>       toolchain/gcc: sprinkle with some calls to MESSAGE
>       toolchain/kernel-headers: sprinkle with some calls to MESSAGE
>       toolchain/uClibc: sprinkle with some calls to MESSAGE
>       fs/common.mk: delay evaluation of variables.
>       pkg-infra: log current message

Arg! Arnout's authorship was lost when I added his patch to my tree... :-(
Let me fix that...

[git-am choked on the patch because of some missing "newline at end
of file", hence I applied it manually, and forgot to change authorship]

Regards,
Yann E. MORIN.
Yann E. MORIN - Jan. 20, 2013, 4:44 p.m.
All,

On Sunday 20 January 2013 Yann E. MORIN wrote:
> On Sunday 20 January 2013 Yann E. MORIN wrote:
> > This series adds some intrumentation to the pkg-infra so that it is easier
> > for the autobuilders to extract meaningfull information about the reason
> > of failures.
> [--SNIP--]
> > Yann E. MORIN (7):
> >       toolchain/external: sprinkle with some calls to MESSAGE
> >       toolchain/crosstool-ng: sprinkle with some calls to MESSAGE
> >       toolchain/gcc: sprinkle with some calls to MESSAGE
> >       toolchain/kernel-headers: sprinkle with some calls to MESSAGE
> >       toolchain/uClibc: sprinkle with some calls to MESSAGE
> >       fs/common.mk: delay evaluation of variables.
> >       pkg-infra: log current message
> 
> Arg! Arnout's authorship was lost when I added his patch to my tree... :-(
> Let me fix that...

OK, the branch on gitorious has been fixed, now. Not re-sending the series,
though. Please pull form gitorious to ensure Arnout's authorship is
retained.

My apologies for the hiccup. :-(

Regards,
Yann E. MORIN.
Arnout Vandecappelle - Jan. 20, 2013, 5:38 p.m.
On 01/20/13 17:38, Yann E. MORIN wrote:
> [git-am choked on the patch because of some missing "newline at end
> of file", hence I applied it manually, and forgot to change authorship]

  Funny, must be a bug in git-apply.

  Regards,
  Arnout
Peter Korsgaard - Jan. 20, 2013, 9:14 p.m.
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 Yann> Hello All!

 Yann> This series adds some intrumentation to the pkg-infra so that it
 Yann> is easier for the autobuilders to extract meaningfull information
 Yann> about the reason of failures.

Committed patch 1-5, thanks!

 Yann> Yann E. MORIN (7):
 Yann>       toolchain/external: sprinkle with some calls to MESSAGE
 Yann>       toolchain/crosstool-ng: sprinkle with some calls to MESSAGE
 Yann>       toolchain/gcc: sprinkle with some calls to MESSAGE
 Yann>       toolchain/kernel-headers: sprinkle with some calls to MESSAGE
 Yann>       toolchain/uClibc: sprinkle with some calls to MESSAGE
 Yann>       fs/common.mk: delay evaluation of variables.
 Yann>       pkg-infra: log current message