Patchwork configure: don't echo $CFLAGS (issue 7103062)

login
register
mail settings
Submitter minux.ma@gmail.com
Date Jan. 20, 2013, 11:02 a.m.
Message ID <047d7bf0e312c6da3504d3b6483d@google.com>
Download mbox | patch
Permalink /patch/213952/
State New
Headers show

Comments

minux.ma@gmail.com - Jan. 20, 2013, 11:02 a.m.
Reviewers: bonzini_gnu.org, dj_redhat.com, neroden_gcc.gnu.org,  
aoliva_redhat.com, ralf.wildenhues_gmx.de, jakub_redhat.com,  
mikestump_comcast.net,

Description:
2013-01-20  Shenghou Ma  <minux.ma@gmail.com>

	* config/isl.m4: don't echo $CFLAGS for ISL_CHECK_VERSION.
	* configure: Re-generate.


Please review this at https://codereview.appspot.com/7103062/

Affected files:
   M     config/isl.m4
   M     configure
Richard Guenther - Jan. 23, 2013, 12:45 p.m.
On Sun, Jan 20, 2013 at 12:02 PM,  <minux.ma@gmail.com> wrote:
> Reviewers: bonzini_gnu.org, dj_redhat.com, neroden_gcc.gnu.org,
> aoliva_redhat.com, ralf.wildenhues_gmx.de, jakub_redhat.com,
> mikestump_comcast.net,

Ok.

Thanks
Richard.

> Description:
> 2013-01-20  Shenghou Ma  <minux.ma@gmail.com>
>
>         * config/isl.m4: don't echo $CFLAGS for ISL_CHECK_VERSION.
>         * configure: Re-generate.
>
>
> Please review this at https://codereview.appspot.com/7103062/
>
> Affected files:
>   M     config/isl.m4
>   M     configure
>
>
> Index: configure
> ===================================================================
> --- configure   (revision 195313)
> +++ configure   (working copy)
> @@ -5833,7 +5833,6 @@
>      CFLAGS="${_isl_saved_CFLAGS} ${islinc} ${gmpinc}"
>      LDFLAGS="${_isl_saved_LDFLAGS} ${isllibs}"
>      LIBS="${_isl_saved_LIBS} -lisl"
> -    echo $CFLAGS
>
>      { $as_echo "$as_me:${as_lineno-$LINENO}: checking for version 0.10 of
> ISL" >&5
>  $as_echo_n "checking for version 0.10 of ISL... " >&6; }
> @@ -5882,7 +5881,6 @@
>      CFLAGS="${_isl_saved_CFLAGS} ${islinc} ${gmpinc}"
>      LDFLAGS="${_isl_saved_LDFLAGS} ${isllibs}"
>      LIBS="${_isl_saved_LIBS} -lisl"
> -    echo $CFLAGS
>
>      { $as_echo "$as_me:${as_lineno-$LINENO}: checking for version 0.11 of
> ISL" >&5
>  $as_echo_n "checking for version 0.11 of ISL... " >&6; }
> Index: config/isl.m4
> ===================================================================
> --- config/isl.m4       (revision 195313)
> +++ config/isl.m4       (working copy)
> @@ -114,7 +114,6 @@
>      CFLAGS="${_isl_saved_CFLAGS} ${islinc} ${gmpinc}"
>      LDFLAGS="${_isl_saved_LDFLAGS} ${isllibs}"
>      LIBS="${_isl_saved_LIBS} -lisl"
> -    echo $CFLAGS
>
>      AC_MSG_CHECKING([for version $1.$2 of ISL])
>      AC_RUN_IFELSE([_ISL_CHECK_CT_PROG($1,$2)],
>
>

Patch

Index: configure
===================================================================
--- configure	(revision 195313)
+++ configure	(working copy)
@@ -5833,7 +5833,6 @@ 
      CFLAGS="${_isl_saved_CFLAGS} ${islinc} ${gmpinc}"
      LDFLAGS="${_isl_saved_LDFLAGS} ${isllibs}"
      LIBS="${_isl_saved_LIBS} -lisl"
-    echo $CFLAGS

      { $as_echo "$as_me:${as_lineno-$LINENO}: checking for version 0.10 of  
ISL" >&5
  $as_echo_n "checking for version 0.10 of ISL... " >&6; }
@@ -5882,7 +5881,6 @@ 
      CFLAGS="${_isl_saved_CFLAGS} ${islinc} ${gmpinc}"
      LDFLAGS="${_isl_saved_LDFLAGS} ${isllibs}"
      LIBS="${_isl_saved_LIBS} -lisl"
-    echo $CFLAGS

      { $as_echo "$as_me:${as_lineno-$LINENO}: checking for version 0.11 of  
ISL" >&5
  $as_echo_n "checking for version 0.11 of ISL... " >&6; }
Index: config/isl.m4
===================================================================
--- config/isl.m4	(revision 195313)
+++ config/isl.m4	(working copy)
@@ -114,7 +114,6 @@ 
      CFLAGS="${_isl_saved_CFLAGS} ${islinc} ${gmpinc}"
      LDFLAGS="${_isl_saved_LDFLAGS} ${isllibs}"
      LIBS="${_isl_saved_LIBS} -lisl"
-    echo $CFLAGS

      AC_MSG_CHECKING([for version $1.$2 of ISL])
      AC_RUN_IFELSE([_ISL_CHECK_CT_PROG($1,$2)],