Patchwork [1/2] xapp_xinit: only makes sense if there is an X server

login
register
mail settings
Submitter Arnout Vandecappelle
Date Jan. 20, 2013, 10:31 a.m.
Message ID <1358677875-29889-1-git-send-email-arnout@mind.be>
Download mbox | patch
Permalink /patch/213950/
State Accepted
Headers show

Comments

Arnout Vandecappelle - Jan. 20, 2013, 10:31 a.m.
From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
 package/x11r7/xapp_xinit/Config.in |    2 ++
 1 file changed, 2 insertions(+)
Peter Korsgaard - Jan. 20, 2013, 8:22 p.m.
>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:

 Arnout> From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
 Arnout> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
 Arnout> ---
 Arnout>  package/x11r7/xapp_xinit/Config.in |    2 ++
 Arnout>  1 file changed, 2 insertions(+)

 Arnout> diff --git a/package/x11r7/xapp_xinit/Config.in b/package/x11r7/xapp_xinit/Config.in
 Arnout> index 9ac2817..30981c3 100644
 Arnout> --- a/package/x11r7/xapp_xinit/Config.in
 Arnout> +++ b/package/x11r7/xapp_xinit/Config.in
 Arnout> @@ -1,5 +1,7 @@
 Arnout>  config BR2_PACKAGE_XAPP_XINIT
 Arnout>  	bool "xinit"
 Arnout> +	# Runtime dependency: can't start an X server unless there is one
 Arnout> +	depends on BR2_PACKAGE_XSERVER_XORG_SERVER

XAPP_XDM selects XINIT, so I also added the dependency here and
committed both patches, thanks.
Arnout Vandecappelle - Jan. 21, 2013, 7:14 a.m.
On 01/20/13 21:22, Peter Korsgaard wrote:
>>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind)<arnout@mind.be>  writes:
>
>   Arnout>  From: "Arnout Vandecappelle (Essensium/Mind)"<arnout@mind.be>
>   Arnout>  Signed-off-by: Arnout Vandecappelle (Essensium/Mind)<arnout@mind.be>
>   Arnout>  ---
>   Arnout>   package/x11r7/xapp_xinit/Config.in |    2 ++
>   Arnout>   1 file changed, 2 insertions(+)
>
>   Arnout>  diff --git a/package/x11r7/xapp_xinit/Config.in b/package/x11r7/xapp_xinit/Config.in
>   Arnout>  index 9ac2817..30981c3 100644
>   Arnout>  --- a/package/x11r7/xapp_xinit/Config.in
>   Arnout>  +++ b/package/x11r7/xapp_xinit/Config.in
>   Arnout>  @@ -1,5 +1,7 @@
>   Arnout>   config BR2_PACKAGE_XAPP_XINIT
>   Arnout>   	bool "xinit"
>   Arnout>  +	# Runtime dependency: can't start an X server unless there is one
>   Arnout>  +	depends on BR2_PACKAGE_XSERVER_XORG_SERVER
>
> XAPP_XDM selects XINIT, so I also added the dependency here and
> committed both patches, thanks.

  And xdm obviously doesn't make much sense without an X server...

  Regards,
  Arnout

Patch

diff --git a/package/x11r7/xapp_xinit/Config.in b/package/x11r7/xapp_xinit/Config.in
index 9ac2817..30981c3 100644
--- a/package/x11r7/xapp_xinit/Config.in
+++ b/package/x11r7/xapp_xinit/Config.in
@@ -1,5 +1,7 @@ 
 config BR2_PACKAGE_XAPP_XINIT
 	bool "xinit"
+	# Runtime dependency: can't start an X server unless there is one
+	depends on BR2_PACKAGE_XSERVER_XORG_SERVER
 	select BR2_PACKAGE_XAPP_XAUTH
 	select BR2_PACKAGE_XLIB_LIBX11
 	help