From patchwork Sat Jan 19 16:01:34 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Blue Swirl X-Patchwork-Id: 213876 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 48EBD2C0082 for ; Sun, 20 Jan 2013 03:01:59 +1100 (EST) Received: from localhost ([::1]:59510 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Twarl-00052S-H3 for incoming@patchwork.ozlabs.org; Sat, 19 Jan 2013 11:01:57 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58287) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tware-00052M-4L for qemu-devel@nongnu.org; Sat, 19 Jan 2013 11:01:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Twarc-0005W4-E6 for qemu-devel@nongnu.org; Sat, 19 Jan 2013 11:01:50 -0500 Received: from mail-la0-f44.google.com ([209.85.215.44]:36858) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Twarc-0005Ve-6l for qemu-devel@nongnu.org; Sat, 19 Jan 2013 11:01:48 -0500 Received: by mail-la0-f44.google.com with SMTP id eb20so3705781lab.3 for ; Sat, 19 Jan 2013 08:01:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer; bh=gVcENLtow9O370n23IIKmzfblR4twytkHSYdj6DrKds=; b=GBD5ivRwgqS5QKfeTRGIVLdbmFKaxYHeRiOTA45fgh24hKk/+xp9WepX+kATQivQNL lkccHbddWT1uCSCa8KBa0U6Ly/KYSd3/nRiv1pC13IVeqSYIXzQbLg4OINMuBYw0RekR 8vBmFadnSrQGY+97gnlMbSYFGL2wANweT0XWzjZXVKW3S/vNPGQR9CJvXA25A7rENTtA eZaEnV6lDCEdb6wN1oD/+ALg0lID4dq/WMZOnYaPiTwYdl2qLjHsLOm/B4RFSutMGB7C z6YCCXS5py/ewnPMV3J8SWthQZA2MtvkO73rXrf4sZ/pUB7Qb2sybgTjto+qY3VS4lRA O4mw== X-Received: by 10.112.46.66 with SMTP id t2mr5225038lbm.115.1358611306819; Sat, 19 Jan 2013 08:01:46 -0800 (PST) Received: from localhost.localdomain ([2001:5c0:1500:5a00:303d:6d74:273f:7c3e]) by mx.google.com with ESMTPS id o2sm3299549lby.11.2013.01.19.08.01.43 (version=TLSv1 cipher=RC4-SHA bits=128/128); Sat, 19 Jan 2013 08:01:45 -0800 (PST) From: Blue Swirl To: qemu-devel@nongnu.org Date: Sat, 19 Jan 2013 16:01:34 +0000 Message-Id: <25ff34ee279d98866add04ca5a7dbf4c9ea47999.1358611253.git.blauwirbel@gmail.com> X-Mailer: git-send-email 1.7.2.5 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 209.85.215.44 Cc: blauwirbel@gmail.com Subject: [Qemu-devel] [PATCH] tests: add fuzzing to visitor tests X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Perform input tests on random data. Improvement to code coverage for qapi/string-input-visitor.c is about 3 percentage points. Signed-off-by: Blue Swirl --- tests/test-string-input-visitor.c | 49 +++++++++++++++++++++++++++++++++++++ 1 files changed, 49 insertions(+), 0 deletions(-) diff --git a/tests/test-string-input-visitor.c b/tests/test-string-input-visitor.c index 899feda..f6b0093 100644 --- a/tests/test-string-input-visitor.c +++ b/tests/test-string-input-visitor.c @@ -165,6 +165,53 @@ static void test_visitor_in_enum(TestInputVisitorData *data, data->siv = NULL; } +/* Try to crash the visitors */ +static void test_visitor_in_fuzz(TestInputVisitorData *data, + const void *unused) +{ + int64_t ires; + bool bres; + double nres; + char *sres; + EnumOne eres; + Error *errp = NULL; + Visitor *v; + unsigned int i; + char buf[10000]; + + for (i = 0; i < 100; i++) { + unsigned int j; + + j = g_test_rand_int_range(0, sizeof(buf) - 1); + + buf[j] = '\0'; + + if (j != 0) { + for (j--; j != 0; j--) { + buf[j - 1] = (char)g_test_rand_int_range(0, 256); + } + } + + v = visitor_input_test_init(data, buf); + visit_type_int(v, &ires, NULL, &errp); + + v = visitor_input_test_init(data, buf); + visit_type_bool(v, &bres, NULL, &errp); + visitor_input_teardown(data, NULL); + + v = visitor_input_test_init(data, buf); + visit_type_number(v, &nres, NULL, &errp); + + v = visitor_input_test_init(data, buf); + visit_type_str(v, &sres, NULL, &errp); + g_free(sres); + + v = visitor_input_test_init(data, buf); + visit_type_EnumOne(v, &eres, NULL, &errp); + visitor_input_teardown(data, NULL); + } +} + static void input_visitor_test_add(const char *testpath, TestInputVisitorData *data, void (*test_func)(TestInputVisitorData *data, const void *user_data)) @@ -189,6 +236,8 @@ int main(int argc, char **argv) &in_visitor_data, test_visitor_in_string); input_visitor_test_add("/string-visitor/input/enum", &in_visitor_data, test_visitor_in_enum); + input_visitor_test_add("/string-visitor/input/fuzz", + &in_visitor_data, test_visitor_in_fuzz); g_test_run();