From patchwork Sat Jan 19 11:47:56 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Shuai X-Patchwork-Id: 213829 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id D92002C007B for ; Sat, 19 Jan 2013 22:49:31 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751961Ab3ASLt1 (ORCPT ); Sat, 19 Jan 2013 06:49:27 -0500 Received: from mail-pb0-f46.google.com ([209.85.160.46]:48026 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751909Ab3ASLt0 (ORCPT ); Sat, 19 Jan 2013 06:49:26 -0500 Received: by mail-pb0-f46.google.com with SMTP id wy7so2501551pbc.19 for ; Sat, 19 Jan 2013 03:49:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer; bh=drXxNuvolwzAAY7jy0a4XKRaj17xbTUn9rQiEqFd8NA=; b=EFZoBkAnoHAusfcVef5nxLXqRNFr/FM8y1ATSdMHzZQ2D6y30PIcg3DfBZKYT0OG7Y mN9wKPkjcfHZjqJ5N4kxeTKzGLT3Wx9T/sjlE68g1o0898ur53hpL/CFZRwENPNhCrB9 9wWNKS/A7tew6OVww13pvtXFow1SUUHJSEt6ByHpVZKoD92G5yNsmUPMpiIDkyw0GjK9 KLdMsarJAAxpakXthR0LcV3iTLGD4g2Mw/Jo3RHu6y3WGZ8cdFL4osRnjXez6Zg8jZPA k1ci4AyPWlNReN4miggAvjuFy37/WbOz4fVvR0iNLhGLWZqxbzkK50EtNgeAEiXNFlbr QSyA== X-Received: by 10.68.222.232 with SMTP id qp8mr32625647pbc.99.1358596166091; Sat, 19 Jan 2013 03:49:26 -0800 (PST) Received: from localhost.localdomain ([101.86.145.45]) by mx.google.com with ESMTPS id uk9sm4888920pbc.63.2013.01.19.03.48.56 (version=TLSv1 cipher=RC4-SHA bits=128/128); Sat, 19 Jan 2013 03:49:25 -0800 (PST) From: Wei Shuai To: dbbw@redhat.com, davem@davemloft.net, peter@stuge.se, oneukum@suse.de, sshtylyov@mvista.com, gregkh@linuxfoundation.org, alexey.orishko@stericsson.com, bjorn@mork.no Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, Wei Shuai Subject: [PATCH 1/2] introduce flag FLAG_NOARP for usb net devices which cannot do ARP Date: Sat, 19 Jan 2013 19:47:56 +0800 Message-Id: <1358596079-7126-1-git-send-email-cpuwolf@gmail.com> X-Mailer: git-send-email 1.7.6.5 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org we do have some USB net devices, which cannot do ARP. so we can introduce a new flag FLAG_NOARP, then client drivers can easily handle these kind of devices Signed-off-by: Wei Shuai --- drivers/net/usb/usbnet.c | 4 ++++ include/linux/usb/usbnet.h | 1 + 2 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c index 3d4bf01..f34b2eb 100644 --- a/drivers/net/usb/usbnet.c +++ b/drivers/net/usb/usbnet.c @@ -1448,6 +1448,10 @@ usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod) if ((dev->driver_info->flags & FLAG_WWAN) != 0) strcpy(net->name, "wwan%d"); + /* devices that cannot do ARP */ + if ((dev->driver_info->flags & FLAG_NOARP) != 0) + net->flags |= IFF_NOARP; + /* maybe the remote can't receive an Ethernet MTU */ if (net->mtu > (dev->hard_mtu - net->hard_header_len)) net->mtu = dev->hard_mtu - net->hard_header_len; diff --git a/include/linux/usb/usbnet.h b/include/linux/usb/usbnet.h index bd45eb7..5de7a22 100644 --- a/include/linux/usb/usbnet.h +++ b/include/linux/usb/usbnet.h @@ -100,6 +100,7 @@ struct driver_info { #define FLAG_LINK_INTR 0x0800 /* updates link (carrier) status */ #define FLAG_POINTTOPOINT 0x1000 /* possibly use "usb%d" names */ +#define FLAG_NOARP 0x2000 /* device can't do ARP */ /* * Indicates to usbnet, that USB driver accumulates multiple IP packets.