From patchwork Sat Jan 19 09:02:16 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [02/21] NTB: Handle ntb client device probes without present hardware Date: Fri, 18 Jan 2013 23:02:16 -0000 From: Jon Mason X-Patchwork-Id: 213801 Message-Id: <1358586155-23322-3-git-send-email-jon.mason@intel.com> To: Greg KH Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Dave Jiang , Nicholas Bellinger Attempts to probe client ntb drivers without ntb hardware present will result in null pointer dereference due to the lack of the ntb bus device being registers. Check to see if this is the case, and fail all calls by the clients registering their drivers. Signed-off-by: Jon Mason --- drivers/ntb/ntb_transport.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c index 250190f..1d17857 100644 --- a/drivers/ntb/ntb_transport.c +++ b/drivers/ntb/ntb_transport.c @@ -288,6 +288,9 @@ int ntb_register_client_dev(char *device_name) struct ntb_transport *nt; int rc; + if (list_empty(&ntb_transport_list)) + return -ENODEV; + list_for_each_entry(nt, &ntb_transport_list, entry) { struct device *dev; @@ -336,6 +339,9 @@ int ntb_register_client(struct ntb_client *drv) { drv->driver.bus = &ntb_bus_type; + if (list_empty(&ntb_transport_list)) + return -ENODEV; + return driver_register(&drv->driver); } EXPORT_SYMBOL_GPL(ntb_register_client);