From patchwork Sat Jan 19 09:02:34 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jon Mason X-Patchwork-Id: 213786 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id CAF7A2C007E for ; Sat, 19 Jan 2013 20:05:26 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751946Ab3ASJEb (ORCPT ); Sat, 19 Jan 2013 04:04:31 -0500 Received: from mga09.intel.com ([134.134.136.24]:20759 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752101Ab3ASJDX (ORCPT ); Sat, 19 Jan 2013 04:03:23 -0500 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 19 Jan 2013 01:02:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.84,498,1355126400"; d="scan'208";a="274089858" Received: from jonmason-lab.ch.intel.com (HELO jonmason-lab) ([143.182.51.20]) by orsmga002.jf.intel.com with SMTP; 19 Jan 2013 01:03:21 -0800 Received: by jonmason-lab (sSMTP sendmail emulation); Sat, 19 Jan 2013 02:03:21 -0700 From: Jon Mason To: Greg KH Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Dave Jiang , Nicholas Bellinger Subject: [PATCH 20/21] ntb_netdev: improve logging Date: Sat, 19 Jan 2013 02:02:34 -0700 Message-Id: <1358586155-23322-21-git-send-email-jon.mason@intel.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1358586155-23322-1-git-send-email-jon.mason@intel.com> References: <1358586155-23322-1-git-send-email-jon.mason@intel.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Improve driver logging to be more helpful Signed-off-by: Jon Mason --- drivers/net/ntb_netdev.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/ntb_netdev.c b/drivers/net/ntb_netdev.c index 37173ce..02213a8 100644 --- a/drivers/net/ntb_netdev.c +++ b/drivers/net/ntb_netdev.c @@ -153,7 +153,7 @@ static netdev_tx_t ntb_netdev_start_xmit(struct sk_buff *skb, struct ntb_netdev *dev = netdev_priv(ndev); int rc; - netdev_dbg(ndev, "ntb_transport_tx_enqueue\n"); + netdev_dbg(ndev, "%s: skb len %d\n", __func__, skb->len); rc = ntb_transport_tx_enqueue(dev->qp, skb, skb->data, skb->len); if (rc) @@ -355,7 +355,7 @@ static int ntb_netdev_probe(struct pci_dev *pdev) goto err1; list_add(&dev->list, &dev_list); - pr_info("%s: %s created\n", KBUILD_MODNAME, ndev->name); + dev_info(&pdev->dev, "%s created\n", ndev->name); return 0; err1: @@ -408,6 +408,5 @@ static void __exit ntb_netdev_exit_module(void) { ntb_unregister_client(&ntb_netdev_client); ntb_unregister_client_dev(KBUILD_MODNAME); - pr_info("%s: Driver removed\n", KBUILD_MODNAME); } module_exit(ntb_netdev_exit_module);