From patchwork Fri Jan 18 17:05:18 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Janis Johnson X-Patchwork-Id: 213680 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id E170A2C0079 for ; Sat, 19 Jan 2013 04:03:05 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1359133386; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Message-ID:Date:From:Reply-To:User-Agent:MIME-Version: To:Subject:Content-Type:Mailing-List:Precedence:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=TfsBdw6jFcTGQ9asJ7/yO6ehRDk=; b=V3DfaO3i7Vu2J2I kX8Hik5BEG+sQh14CiSsPyBZtRI8jnrw9iknZy/GnvIP4mlQ3kgrnXN24RK2HcmH la85v+rDxdWn+T+nGEGI0bRgTQFHoZ47rWhP+TX8FnfA7d3oz4gSjmIVa5e/LAII e/B4qrtyyZHaRS6m5ugxaSR/foso= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:Message-ID:Date:From:Reply-To:User-Agent:MIME-Version:To:Subject:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=tXP2PFp53SeM6COz8w7xIY16fKzr14iCoUn12kl+y4VpSC4NTBLntcKPSBPBbO wru9I3KXXj7x2xDsnV7XEAJcsx6FcuwMLWwJ1FuoAaMwfnXDbkql3779tqGERZho GKwir6ZqwXENFy0SxILFstdo5u77OzZVaHn8/XIBNOIM8=; Received: (qmail 2592 invoked by alias); 18 Jan 2013 17:02:59 -0000 Received: (qmail 2583 invoked by uid 22791); 18 Jan 2013 17:02:57 -0000 X-SWARE-Spam-Status: No, hits=-3.8 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, RCVD_IN_HOSTKARMA_W, RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 18 Jan 2013 17:02:48 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1TwFL4-0004na-Qp from Janis_Johnson@mentor.com for gcc-patches@gcc.gnu.org; Fri, 18 Jan 2013 09:02:46 -0800 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Fri, 18 Jan 2013 09:02:46 -0800 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.1.289.1; Fri, 18 Jan 2013 09:02:45 -0800 Message-ID: <50F980CE.6030609@mentor.com> Date: Fri, 18 Jan 2013 09:05:18 -0800 From: Janis Johnson Reply-To: User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.28) Gecko/20120313 Thunderbird/3.1.20 MIME-Version: 1.0 To: "gcc-patches@gcc.gnu.org" Subject: testsuite] clean up convoluted dg-final directive in vect-multitypes-12.c Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Test gcc.dg/vect/vect-multitypes uses Tcl conditions within a dg-final directive, which is something that DejaGnu handles but we strive not to do. It's now possible to use supported constructs to get the same result, so I've cleaned up the test and checked it in as obvious. I'm fixing this particular test because I want to add an xfail but want to keep that change separate from the cleanup. Janis 2013-01-18 Janis Johnson * gcc.dg/vect/vect-multitypes-12.c: Refactor dg-final directive. Index: gcc/testsuite/gcc.dg/vect/vect-multitypes-12.c =================================================================== --- gcc/testsuite/gcc.dg/vect/vect-multitypes-12.c (revision 195286) +++ gcc/testsuite/gcc.dg/vect/vect-multitypes-12.c (working copy) @@ -38,7 +38,9 @@ return 0; } +/* bleah */ /* { dg-final { scan-tree-dump-times "vectorized 1 loops" 2 "vect" { target vect_unpack } } } */ -/* { dg-final { if [ istarget sparc*-*-* ] { scan-tree-dump-times "vectorized 1 loops" 1 "vect" { xfail ilp32 } } else { scan-tree-dump-times "vectorized 1 loops" 1 "vect" { target { ! vect_unpack } } } } } */ +/* { dg-final { scan-tree-dump-times "vectorized 1 loops" 1 "vect" { target sparc*-*-* xfail ilp32 } } } */ +/* { dg-final { scan-tree-dump-times "vectorized 1 loops" 1 "vect" { target { { ! sparc*-*-* } && { ! vect_unpack } } } } } */ /* { dg-final { cleanup-tree-dump "vect" } } */