Patchwork [2/8] ide: Remove wrong assertion

login
register
mail settings
Submitter Stefan Hajnoczi
Date Jan. 18, 2013, 4:28 p.m.
Message ID <1358526521-24300-3-git-send-email-stefanha@redhat.com>
Download mbox | patch
Permalink /patch/213672/
State New
Headers show

Comments

Stefan Hajnoczi - Jan. 18, 2013, 4:28 p.m.
From: Kevin Wolf <kwolf@redhat.com>

The Bus Master IDE Active bit (BM_STATUS_DMAING) is not only set when
the request is still in flight, but also when it has completed and the
size of the physical memory regions in the PRDT was larger than the
transfer size.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 hw/ide/pci.c | 1 -
 1 file changed, 1 deletion(-)

Patch

diff --git a/hw/ide/pci.c b/hw/ide/pci.c
index e6226e3..59fd539 100644
--- a/hw/ide/pci.c
+++ b/hw/ide/pci.c
@@ -311,7 +311,6 @@  void bmdma_cmd_writeb(BMDMAState *bm, uint32_t val)
             if (bm->bus->dma->aiocb) {
                 bdrv_drain_all();
                 assert(bm->bus->dma->aiocb == NULL);
-                assert((bm->status & BM_STATUS_DMAING) == 0);
             }
         } else {
             bm->cur_addr = bm->addr;