From patchwork Fri Jan 18 16:28:31 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liu Yuan X-Patchwork-Id: 213671 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 42D5D2C007C for ; Sat, 19 Jan 2013 03:28:58 +1100 (EST) Received: from localhost ([::1]:39386 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TwEoK-0000wJ-Dk for incoming@patchwork.ozlabs.org; Fri, 18 Jan 2013 11:28:56 -0500 Received: from eggs.gnu.org ([208.118.235.92]:53797) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TwEo9-0000uQ-4D for qemu-devel@nongnu.org; Fri, 18 Jan 2013 11:28:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TwEo5-0004hh-53 for qemu-devel@nongnu.org; Fri, 18 Jan 2013 11:28:45 -0500 Received: from mail-pb0-f43.google.com ([209.85.160.43]:54026) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TwEo4-0004hJ-Vd for qemu-devel@nongnu.org; Fri, 18 Jan 2013 11:28:41 -0500 Received: by mail-pb0-f43.google.com with SMTP id jt11so763631pbb.30 for ; Fri, 18 Jan 2013 08:28:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=WcMlWb5TJkK5DVvvrml9FIaLTLMQvxK4gV+a6tDVswU=; b=Vv8Ox7Y3vDPnviYIXxpO2EM/vHpuRwVhXfXHZEunH2pvsoXagDkRJVGjWr3DNxQVKa vgk4C3q4RoHexbZNyK5UewXcjSpetgCwMHC53OVoPrquTs4PtY83sxJi8KjYrJVXeDGf JKIrriT7UAn4lPdvKmVwGmIDe13p0cdLsgqoSbleTByYtdfY4iDq9o2eyWstNN0NAE5e DgJUaHmeNFnv58X6Dbm4ppFdaYoRrDNmsoSesPFnG3l3hwsJaxPPfAyx23v+XNCVqnMt tel4sx0GmwFP0YNBX1U7JVxipDW+lr0gngAbhKQpzKIJZTc3JRckSnDR22wEpJALa/Zy mimw== X-Received: by 10.68.238.106 with SMTP id vj10mr6966473pbc.40.1358526520230; Fri, 18 Jan 2013 08:28:40 -0800 (PST) Received: from [192.168.1.105] ([221.217.164.196]) by mx.google.com with ESMTPS id qt3sm3346092pbb.32.2013.01.18.08.28.34 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 18 Jan 2013 08:28:38 -0800 (PST) Message-ID: <50F9782F.5090401@gmail.com> Date: Sat, 19 Jan 2013 00:28:31 +0800 From: Liu Yuan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 To: Stefan Hajnoczi References: <50F96D92.6080301@gmail.com> In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 209.85.160.43 Cc: Kevin Wolf , Paolo Bonzini , qemu-devel Subject: Re: [Qemu-devel] bdrv_co_flush_to_disk() don't flush as expected X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On 01/18/2013 11:56 PM, Stefan Hajnoczi wrote: > How are you checking that sd_co_flush_to_disk() is called? Please > post the diff. Okay, this is where I added printf(). Yuan } diff --git a/block/sheepdog.c b/block/sheepdog.c index 3e49bb8..41edd46 100644 --- a/block/sheepdog.c +++ b/block/sheepdog.c @@ -1714,6 +1714,7 @@ static int coroutine_fn sd_co_flush_to_disk(BlockDriverState *bs) AIOReq *aio_req; int ret; + printf("hello\n"); if (s->cache_flags != SD_FLAG_CMD_CACHE) { return 0;