| Message ID | 50F93932.60700@cideas.com |
|---|---|
| State | Superseded |
| Delegated to: | Jerry Van Baren |
| Headers | show |
On Fri, Jan 18, 2013 at 06:59:46AM -0500, Gerald Van Baren wrote: > On 01/17/2013 06:50 PM, David Gibson wrote: > > On Thu, Jan 17, 2013 at 01:32:45PM -0500, Jerry Van Baren wrote: > >> Hi Scott, Kim, David, > > [snip] > > >> libfdt_env.h is where Kim typedef'ed fdt16_t, fdt32_t, fdt64_t > >> > >> I suspect the original intent was to have <libfdt.h> be the file > >> that people #included. For whatever reason, most includes are > >> (picking on fdt_ro.c arbitrarily): 51 #include "libfdt_env.h" 53 > >> #include <fdt.h> 54 #include <libfdt.h> Since libfdt.h #includes > >> fdt.h and libfdt_env.h, lines 51 and 53 (above) are redundant. > >> It sorts out OK in dtc because libfdt_env.h includes stdint.h and > >> defines fdt*_t, but it messes me up in u-boot where (currently) > >> libfdt_env.h does *not* include stdint.h... > > > > Ok, so, the uboot libfdt_env.h should be fixed to define uintXX_t > > and fdtXX_t (either by including stdint or my other means). The > > purpose of libfdt_env.h is to define the things that libfdt > > requires, and those types are (now) such a requirement. > > I like the move, but have not done it (yet). I made a trial patch > (see below) that uses libfdt.h as the interface and cleans out the > (now redundant) other *fdt*.h includes. If this is in the right > direction, I'll move the fdtXX_t typedefs and formally submit it. > > The test suite has one failure, but it fails with or without my changes. > > $ make check | grep FAIL > fdtget-runtest.sh 77 121 66 111 97 114 100 78 97 109 101 0 77 121 66 > 111 97 114 100 70 97 109 105 108 121 78 97 109 101 0 > label01.dts.fdtget.test.dtb / compatible: FAIL Results differ from > expected > * FAIL: 1 > > ********** TEST SUMMARY > * Total testcases: 1443 > * PASS: 1442 > * FAIL: 1 > * Bad configuration: 0 > * Strange test result: 0 > ********** Yeah, Jon and I are aware of that recently introduced bug. I've had other projects to attend to and haven't had a chance to fix it yet. It's basically a testsuite bug though, so it should be harmless.
diff --git a/dtc.h b/dtc.h index 3e42a07..a032645 100644 --- a/dtc.h +++ b/dtc.h @@ -32,8 +32,7 @@ #include <errno.h> #include <unistd.h> -#include <libfdt_env.h> -#include <fdt.h> +#include <libfdt.h> #include "util.h" diff --git a/fdtdump.c b/fdtdump.c index b2c5b37..3919490 100644 --- a/fdtdump.c +++ b/fdtdump.c @@ -8,8 +8,7 @@ #include <string.h> #include <ctype.h> -#include <libfdt_env.h> -#include <fdt.h> +#include <libfdt.h> #include "util.h" diff --git a/libfdt/fdt.c b/libfdt/fdt.c index 57faba3..19b9043 100644 --- a/libfdt/fdt.c +++ b/libfdt/fdt.c @@ -48,11 +48,8 @@ * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, * EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ -#include "libfdt_env.h" -#include <fdt.h> #include <libfdt.h> - #include "libfdt_internal.h" int fdt_check_header(const void *fdt) diff --git a/libfdt/fdt_empty_tree.c b/libfdt/fdt_empty_tree.c index f72d13b..30c5525 100644 --- a/libfdt/fdt_empty_tree.c +++ b/libfdt/fdt_empty_tree.c @@ -48,11 +48,8 @@ * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, * EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ -#include "libfdt_env.h" -#include <fdt.h> #include <libfdt.h> - #include "libfdt_internal.h" int fdt_create_empty_tree(void *buf, int bufsize) diff --git a/libfdt/fdt_ro.c b/libfdt/fdt_ro.c index 42da2bd..53c61ed 100644 --- a/libfdt/fdt_ro.c +++ b/libfdt/fdt_ro.c @@ -48,11 +48,8 @@ * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, * EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ -#include "libfdt_env.h" -#include <fdt.h> #include <libfdt.h> - #include "libfdt_internal.h" static int _fdt_nodename_eq(const void *fdt, int offset, diff --git a/libfdt/fdt_rw.c b/libfdt/fdt_rw.c index fdba618..b6a8815 100644 --- a/libfdt/fdt_rw.c +++ b/libfdt/fdt_rw.c @@ -48,11 +48,8 @@ * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, * EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ -#include "libfdt_env.h" -#include <fdt.h> #include <libfdt.h> - #include "libfdt_internal.h" static int _fdt_blocks_misordered(const void *fdt, diff --git a/libfdt/fdt_strerror.c b/libfdt/fdt_strerror.c index e6c3cee..c55793c 100644 --- a/libfdt/fdt_strerror.c +++ b/libfdt/fdt_strerror.c @@ -48,11 +48,8 @@ * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, * EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ -#include "libfdt_env.h" -#include <fdt.h> #include <libfdt.h> - #include "libfdt_internal.h" struct fdt_errtabent { diff --git a/libfdt/fdt_sw.c b/libfdt/fdt_sw.c index f422754..85aaedf 100644 --- a/libfdt/fdt_sw.c +++ b/libfdt/fdt_sw.c @@ -48,11 +48,8 @@ * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, * EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ -#include "libfdt_env.h" -#include <fdt.h> #include <libfdt.h> - #include "libfdt_internal.h" static int _fdt_sw_check_header(void *fdt) diff --git a/libfdt/fdt_wip.c b/libfdt/fdt_wip.c index c5bbb68..67fa7ca 100644 --- a/libfdt/fdt_wip.c +++ b/libfdt/fdt_wip.c @@ -48,11 +48,8 @@ * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, * EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ -#include "libfdt_env.h" -#include <fdt.h> #include <libfdt.h> - #include "libfdt_internal.h" int fdt_setprop_inplace(void *fdt, int nodeoffset, const char *name, diff --git a/libfdt/libfdt_internal.h b/libfdt/libfdt_internal.h index 381133b..a8b36f4 100644 --- a/libfdt/libfdt_internal.h +++ b/libfdt/libfdt_internal.h @@ -50,7 +50,6 @@ * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, * EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ -#include <fdt.h> #define FDT_ALIGN(x, a) (((x) + (a) - 1) & ~((a) - 1)) #define FDT_TAGALIGN(x) (FDT_ALIGN((x), FDT_TAGSIZE))