From patchwork Thu Jan 17 17:18:29 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nickolai Zeldovich X-Patchwork-Id: 213341 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4628C2C007A for ; Fri, 18 Jan 2013 04:44:15 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753641Ab3AQRoM (ORCPT ); Thu, 17 Jan 2013 12:44:12 -0500 Received: from amsterdam.lcs.mit.edu ([18.26.4.9]:28155 "EHLO amsterdam.lcs.mit.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752472Ab3AQRoK (ORCPT ); Thu, 17 Jan 2013 12:44:10 -0500 X-Greylist: delayed 1534 seconds by postgrey-1.27 at vger.kernel.org; Thu, 17 Jan 2013 12:44:10 EST Received: (from root@localhost) by amsterdam.lcs.mit.edu (8.14.4/8.13.8) id r0HHIYLY047161; Thu, 17 Jan 2013 12:18:34 -0500 (EST) (envelope-from nickolai@amsterdam.lcs.mit.edu) Received: from ben.csail.mit.edu (ben.csail.mit.edu [18.26.4.122]) (TLSv1/SSLv3 DHE-RSA-AES128-SHA 128/128) by amsterdam.lcs.mit.edu with SMTP; Thu, 17 Jan 2013 12:18:34 -0500 (EST) (envelope-from nickolai@pdos.csail.mit.edu) Received: from nickolai by ben.csail.mit.edu with local (Exim 4.80) (envelope-from ) id 1Tvt6o-000GVC-Fp; Thu, 17 Jan 2013 12:18:34 -0500 From: Nickolai Zeldovich To: netdev@vger.kernel.org Cc: Nickolai Zeldovich , linux-kernel@vger.kernel.org Subject: [PATCH] 3c574_cs: fix operator precedence between << and & Date: Thu, 17 Jan 2013 12:18:29 -0500 Message-Id: <1358443109-63402-1-git-send-email-nickolai@csail.mit.edu> X-Mailer: git-send-email 1.7.10.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The code to print the FIFO size in tc574_config computes it as: 8 << config & Ram_size which evaluates the '<<' first, but the actual intent is to evaluate the '&' first. Add parentheses to enforce desired evaluation order. Signed-off-by: Nickolai Zeldovich --- drivers/net/ethernet/3com/3c574_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/3com/3c574_cs.c b/drivers/net/ethernet/3com/3c574_cs.c index 66df936..ffd8de2 100644 --- a/drivers/net/ethernet/3com/3c574_cs.c +++ b/drivers/net/ethernet/3com/3c574_cs.c @@ -432,7 +432,7 @@ static int tc574_config(struct pcmcia_device *link) netdev_info(dev, "%s at io %#3lx, irq %d, hw_addr %pM\n", cardname, dev->base_addr, dev->irq, dev->dev_addr); netdev_info(dev, " %dK FIFO split %s Rx:Tx, %sMII interface.\n", - 8 << config & Ram_size, + 8 << (config & Ram_size), ram_split[(config & Ram_split) >> Ram_split_shift], config & Autoselect ? "autoselect " : "");