From patchwork Thu Jan 17 15:16:34 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Mammedov X-Patchwork-Id: 213312 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id C147A2C0082 for ; Fri, 18 Jan 2013 02:31:36 +1100 (EST) Received: from localhost ([::1]:55656 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvrFp-00047U-Hv for incoming@patchwork.ozlabs.org; Thu, 17 Jan 2013 10:19:45 -0500 Received: from eggs.gnu.org ([208.118.235.92]:53731) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvrF3-0001mS-DV for qemu-devel@nongnu.org; Thu, 17 Jan 2013 10:18:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TvrF1-0005H6-Jy for qemu-devel@nongnu.org; Thu, 17 Jan 2013 10:18:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44896) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvrF1-0005Fu-Am for qemu-devel@nongnu.org; Thu, 17 Jan 2013 10:18:55 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0HFIsZ1031393 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 17 Jan 2013 10:18:54 -0500 Received: from dell-pet610-01.lab.eng.brq.redhat.com (dell-pet610-01.lab.eng.brq.redhat.com [10.34.42.20]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r0HFIig1006611; Thu, 17 Jan 2013 10:18:53 -0500 From: Igor Mammedov To: qemu-devel@nongnu.org Date: Thu, 17 Jan 2013 16:16:34 +0100 Message-Id: <1358435794-8406-6-git-send-email-imammedo@redhat.com> In-Reply-To: <1358435794-8406-1-git-send-email-imammedo@redhat.com> References: <1358435794-8406-1-git-send-email-imammedo@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: ehabkost@redhat.com, afaerber@suse.de Subject: [Qemu-devel] [PATCH 5/5] target-i386: remove setting tsc-frequency from x86_def_t X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Setting tsc-frequency from x86_def_t is NOP because default tsc_khz in x86_def_t is 0 and CPUX86State.tsc_khz is also initialized to 0 by default. So there is not need to set ovewrite tsc_khz with default 0 because field was already initialized to 0. custom tsc-frequency setting is not affected due to it is being set without using x86_def_t (previous patch) Field tsc_khz in x86_def_t becomes unused with this patch, so drop it as well. Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost --- v2: - rebased with "target-i386: move out CPU features initialization in separate func" patch dropped --- target-i386/cpu.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 50e10b1..cc20ada 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -357,7 +357,6 @@ typedef struct x86_def_t { int family; int model; int stepping; - int tsc_khz; uint32_t features, ext_features, ext2_features, ext3_features; uint32_t kvm_features, svm_features; uint32_t xlevel; @@ -1588,8 +1587,6 @@ int cpu_x86_register(X86CPU *cpu, const char *cpu_model) env->cpuid_ext4_features = def->ext4_features; env->cpuid_7_0_ebx_features = def->cpuid_7_0_ebx_features; env->cpuid_xlevel2 = def->xlevel2; - object_property_set_int(OBJECT(cpu), (int64_t)def->tsc_khz * 1000, - "tsc-frequency", &error); object_property_set_str(OBJECT(cpu), def->model_id, "model-id", &error);