From patchwork Thu Jan 17 10:44:41 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [v2] win32-aio: use iov utility functions instead of open-coding them Date: Thu, 17 Jan 2013 00:44:41 -0000 From: Michael Tokarev X-Patchwork-Id: 213227 Message-Id: <1358419481-22728-1-git-send-email-mjt@msgid.tls.msk.ru> To: Kevin Wolf Cc: pbonzini@redhat.com, Michael Tokarev , qemu-devel@nongnu.org, stefanha@redhat.com We have iov_from_buf() and iov_to_buf(), use them instead of open-coding these in block/win32-aio.c --- block/win32-aio.c | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/block/win32-aio.c b/block/win32-aio.c index b9236ea..b10a0c0 100644 --- a/block/win32-aio.c +++ b/block/win32-aio.c @@ -80,13 +80,7 @@ static void win32_aio_process_completion(QEMUWin32AIOState *s, if (!waiocb->is_linear) { if (ret == 0 && waiocb->is_read) { QEMUIOVector *qiov = waiocb->qiov; - char *p = waiocb->buf; - int i; - - for (i = 0; i < qiov->niov; ++i) { - memcpy(qiov->iov[i].iov_base, p, qiov->iov[i].iov_len); - p += qiov->iov[i].iov_len; - } + iov_from_buf(qiov->iov, qiov->niov, 0, waiocb->buf, qiov->size); } qemu_vfree(waiocb->buf); } @@ -153,13 +147,7 @@ BlockDriverAIOCB *win32_aio_submit(BlockDriverState *bs, if (qiov->niov > 1) { waiocb->buf = qemu_blockalign(bs, qiov->size); if (type & QEMU_AIO_WRITE) { - char *p = waiocb->buf; - int i; - - for (i = 0; i < qiov->niov; ++i) { - memcpy(p, qiov->iov[i].iov_base, qiov->iov[i].iov_len); - p += qiov->iov[i].iov_len; - } + iov_to_buf(qiov->iov, qiov->niov, 0, waiocb->buf, qiov->size); } waiocb->is_linear = false; } else {