Patchwork [v7,22/22] mdf: omap-usb-host: get rid of build warning

login
register
mail settings
Submitter Roger Quadros
Date Jan. 17, 2013, 11:30 a.m.
Message ID <1358422231-24736-23-git-send-email-rogerq@ti.com>
Download mbox | patch
Permalink /patch/213217/
State New
Headers show

Comments

Roger Quadros - Jan. 17, 2013, 11:30 a.m.
Fixes the below build warning when driver is built-in.

drivers/mfd/omap-usb-host.c:750:12: warning:
‘usbhs_omap_remove’ defined but not used [-Wunused-function]

Signed-off-by: Roger Quadros <rogerq@ti.com>
---
 drivers/mfd/omap-usb-host.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Felipe Balbi - Jan. 17, 2013, 11:50 a.m.
On Thu, Jan 17, 2013 at 01:30:31PM +0200, Roger Quadros wrote:
> Fixes the below build warning when driver is built-in.
> 
> drivers/mfd/omap-usb-host.c:750:12: warning:
> ‘usbhs_omap_remove’ defined but not used [-Wunused-function]
> 
> Signed-off-by: Roger Quadros <rogerq@ti.com>

should this go to stable too ?

(though it's not really a bug, so doesn't really matter, I guess).
Roger Quadros - Jan. 17, 2013, 1:30 p.m.
On 01/17/2013 01:50 PM, Felipe Balbi wrote:
> On Thu, Jan 17, 2013 at 01:30:31PM +0200, Roger Quadros wrote:
>> Fixes the below build warning when driver is built-in.
>>
>> drivers/mfd/omap-usb-host.c:750:12: warning:
>> ‘usbhs_omap_remove’ defined but not used [-Wunused-function]
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
> 
> should this go to stable too ?
> 
> (though it's not really a bug, so doesn't really matter, I guess).
> 
not a bug so let's not send this to stable.

--
cheers,
-roger

Patch

diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
index a1f73dc..b726a74 100644
--- a/drivers/mfd/omap-usb-host.c
+++ b/drivers/mfd/omap-usb-host.c
@@ -778,7 +778,7 @@  static struct platform_driver usbhs_omap_driver = {
 		.owner		= THIS_MODULE,
 		.pm		= &usbhsomap_dev_pm_ops,
 	},
-	.remove		= __exit_p(usbhs_omap_remove),
+	.remove		= usbhs_omap_remove,
 };
 
 MODULE_AUTHOR("Keshava Munegowda <keshava_mgowda@ti.com>");