From patchwork Thu Jan 17 10:25:00 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [net-next] team: do not use -ENOENT Date: Thu, 17 Jan 2013 00:25:00 -0000 From: Jiri Pirko X-Patchwork-Id: 213199 Message-Id: <1358418300-2346-1-git-send-email-jiri@resnulli.us> To: netdev@vger.kernel.org Cc: davem@davemloft.net Since this error code means "No such file or directory", change this value in team driver to ones which make more sense. Signed-off-by: Jiri Pirko --- drivers/net/team/team.c | 4 ++-- drivers/net/team/team_mode_activebackup.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index 70d5d6b..3d7cf6e 100644 --- a/drivers/net/team/team.c +++ b/drivers/net/team/team.c @@ -1128,7 +1128,7 @@ static int team_port_del(struct team *team, struct net_device *port_dev) if (!port || !team_port_find(team, port)) { netdev_err(dev, "Device %s does not act as a port of this team\n", portname); - return -ENOENT; + return -ENODEV; } __team_option_inst_mark_removed_port(team, port); @@ -2320,7 +2320,7 @@ static int team_nl_cmd_options_set(struct sk_buff *skb, struct genl_info *info) list_add(&opt_inst->tmp_list, &opt_inst_list); } if (!opt_found) { - err = -ENOENT; + err = -EINVAL; goto team_put; } } diff --git a/drivers/net/team/team_mode_activebackup.c b/drivers/net/team/team_mode_activebackup.c index 6262b4d..2792e13 100644 --- a/drivers/net/team/team_mode_activebackup.c +++ b/drivers/net/team/team_mode_activebackup.c @@ -81,7 +81,7 @@ static int ab_active_port_set(struct team *team, struct team_gsetter_ctx *ctx) return 0; } } - return -ENOENT; + return -ENODEV; } static const struct team_option ab_options[] = {