From patchwork Wed Jan 16 23:49:31 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Janis Johnson X-Patchwork-Id: 213100 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id F2AA72C0092 for ; Thu, 17 Jan 2013 10:48:01 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1358984882; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Message-ID:Date:From:Reply-To:User-Agent:MIME-Version: To:CC:Subject:References:In-Reply-To:Content-Type:Mailing-List: Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:Sender:Delivered-To; bh=wXSXWD/GmOFJynrEXAIEvT8xYgA=; b=c4NtKJj/c3eh+BD0u+1vR5RcQhwRs+8pwf7kdqPV6OR/Z1d/QEiyMdVG8OvuQr ZhvRzpuodD2xWUPozSwXhYPUIHpYcA6fwDmh2uGi3DuMK3ICstAcmJSvN+NS+XEs Sn7B/uMV+HXKUhW6juREQZLUa4FsDcA+d6wAUgIbaa3PQ= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:Message-ID:Date:From:Reply-To:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=rWYLCKPalw7W9kZKN8If78TloU3w82PhvTahd1r5rugwgPjxHD+j3MIAnMuXA/ TCOqD2mBcedb6Juy2o/Vfc2txy5IS0gTJo9diIHcTxVMAtImZEdqK1yATNHuOCZf ZTaIBlJhwSQktMMhsrJPd8HT/AOxGvfkizJF+i/Nwo2Ow=; Received: (qmail 23272 invoked by alias); 16 Jan 2013 23:47:57 -0000 Received: (qmail 23264 invoked by uid 22791); 16 Jan 2013 23:47:56 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, KHOP_THREADED, RCVD_IN_HOSTKARMA_W, RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 16 Jan 2013 23:47:50 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1Tvchw-00043T-6S from Janis_Johnson@mentor.com ; Wed, 16 Jan 2013 15:47:48 -0800 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 16 Jan 2013 15:47:15 -0800 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.1.289.1; Wed, 16 Jan 2013 15:47:15 -0800 Message-ID: <50F73C8B.6040700@mentor.com> Date: Wed, 16 Jan 2013 15:49:31 -0800 From: Janis Johnson Reply-To: User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.28) Gecko/20120313 Thunderbird/3.1.20 MIME-Version: 1.0 To: Nick Clifton CC: , Subject: Re: PING: gcc.target/arm: skip 5 tests for flag conflicts References: <871udl5k5c.fsf@redhat.com> In-Reply-To: <871udl5k5c.fsf@redhat.com> Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On 01/16/2013 05:31 AM, Nick Clifton wrote: > Hi Janis, > >> Back in September I submitted a patch to fix five ARM tests in >> . >> You responded in < http://gcc.gnu.org/ml/gcc-patches/2012-10/msg00972.html> >> and I answered your questions in a reply. > > I believe that Richard's main point was that the skips that you were > adding to the tests meant that they would not be run for valid > command line options. Now I get it. This version is more selective about which multilibs are skipped. I tested it by using multilib test flags for all valid values for -march, with and without -mthumb as appropriate for the arch. The ones that are now skipped are the ones that used to fail with complaints from the compiler. Is this OK? Janis 2013-01-16 Janis Johnson * gcc.target/arm/pr40887.c: Require at least armv5. * gcc.target/arm/pr51835.c: Avoid conflicts with multilib flags. * gcc.target/arm/pr51915.c: Likewise. * gcc.target/arm/pr52006.c: Likewise. * gcc.target/arm/pr53187.c: Likewise. Index: src/gcc-mainline/gcc/testsuite/gcc.target/arm/pr40887.c =================================================================== --- src/gcc-mainline/gcc/testsuite/gcc.target/arm/pr40887.c (revision 195216) +++ src/gcc-mainline/gcc/testsuite/gcc.target/arm/pr40887.c (working copy) @@ -1,3 +1,4 @@ +/* { dg-skip-if "need at least armv5" { *-*-* } { "-march=armv[234]*" } { "" } } */ /* { dg-options "-O2 -march=armv5te" } */ /* { dg-final { scan-assembler "blx" } } */ Index: src/gcc-mainline/gcc/testsuite/gcc.target/arm/pr51835.c =================================================================== --- src/gcc-mainline/gcc/testsuite/gcc.target/arm/pr51835.c (revision 195216) +++ src/gcc-mainline/gcc/testsuite/gcc.target/arm/pr51835.c (working copy) @@ -1,6 +1,8 @@ /* { dg-do compile } */ -/* { dg-options "-O2 -mfloat-abi=hard -mfpu=fpv4-sp-d16" } */ -/* { dg-require-effective-target arm_thumb2_ok } */ +/* { dg-skip-if "no support for hard-float VFP ABI" { arm_thumb1 } { "-march=*" } { "" } } */ +/* { dg-skip-if "do not override -mfloat-abi" { *-*-* } { "-mfloat-abi=*" } { "-mfloat-abi=hard" } } */ +/* { dg-skip-if "avoid conflicting -mfpu" { *-*-* } { "-mfpu=*" } { "-mfpu=fpv4-sp-d16" "-mfpu=vfpv3xd" "-mfpu=vfpv3xd-fp16" } } */ +/* { dg-options "-O2 -march=armv7-a -mfloat-abi=hard -mfpu=fpv4-sp-d16" } */ int func1 (double d) { Index: src/gcc-mainline/gcc/testsuite/gcc.target/arm/pr51915.c =================================================================== --- src/gcc-mainline/gcc/testsuite/gcc.target/arm/pr51915.c (revision 195216) +++ src/gcc-mainline/gcc/testsuite/gcc.target/arm/pr51915.c (working copy) @@ -1,5 +1,7 @@ /* PR target/51915 */ /* { dg-do compile } */ +/* { dg-skip-if "no support for hard-float VFP ABI" { arm_thumb1 } { "-march=*" } { "" } } */ +/* { dg-skip-if "do not override -mfloat-abi" { *-*-* } { "-mfloat-abi=*" } { "-mfloat-abi=hard" } } */ /* { dg-options "-march=armv7-a -mfloat-abi=hard -O2" } */ struct S { int s1; void *s2; }; Index: src/gcc-mainline/gcc/testsuite/gcc.target/arm/pr52006.c =================================================================== --- src/gcc-mainline/gcc/testsuite/gcc.target/arm/pr52006.c (revision 195216) +++ src/gcc-mainline/gcc/testsuite/gcc.target/arm/pr52006.c (working copy) @@ -1,5 +1,7 @@ /* PR target/52006 */ /* { dg-do compile } */ +/* { dg-skip-if "avoid conflicts with multilib flags" { *-*-* } { "-mfloat-abi=*" } { "-mfloat-abi=hard" } } */ +/* { dg-skip-if "no support for hard-float VFP ABI" { arm_thumb1 } { "-march=*" } { "" } } */ /* { dg-options "-march=armv7-a -mfloat-abi=hard -O2 -fPIC" } */ unsigned long a; Index: src/gcc-mainline/gcc/testsuite/gcc.target/arm/pr53187.c =================================================================== --- src/gcc-mainline/gcc/testsuite/gcc.target/arm/pr53187.c (revision 195216) +++ src/gcc-mainline/gcc/testsuite/gcc.target/arm/pr53187.c (working copy) @@ -1,5 +1,7 @@ /* PR target/53187 */ /* { dg-do compile } */ +/* { dg-skip-if "no support for hard-float VFP ABI" { arm_thumb1 } { "-march=*" } { "" } } */ +/* { dg-skip-if "do not override -mfloat-abi" { *-*-* } { "-mfloat-abi=*" } { "-mfloat-abi=hard" } } */ /* { dg-options "-march=armv7-a -mfloat-abi=hard -O2" } */ void bar (int);