Patchwork [5/6] toolchain/kernel-headers: sprinkle with some calls to MESSAGE

login
register
mail settings
Submitter Yann E. MORIN
Date Jan. 16, 2013, 11:41 p.m.
Message ID <5747aa962b6e9d53c7cd0dbd75f391c8999dda70.1358379198.git.yann.morin.1998@free.fr>
Download mbox | patch
Permalink /patch/213097/
State Changes Requested
Headers show

Comments

Yann E. MORIN - Jan. 16, 2013, 11:41 p.m.
Thus, the failing step can be easily extracted by autobuilders,
to ease with post-mortem analysis.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 toolchain/kernel-headers/kernel-headers.mk |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
Markos Chandras - Jan. 18, 2013, 4:16 p.m.
On 16 January 2013 23:41, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> Thus, the failing step can be easily extracted by autobuilders,
> to ease with post-mortem analysis.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
>  toolchain/kernel-headers/kernel-headers.mk |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/toolchain/kernel-headers/kernel-headers.mk b/toolchain/kernel-headers/kernel-headers.mk
> index 568c192..53c4a58 100644
> --- a/toolchain/kernel-headers/kernel-headers.mk
> +++ b/toolchain/kernel-headers/kernel-headers.mk
> @@ -48,6 +48,7 @@ endif
>  LINUX_HEADERS_DEPENDS:=
>
>  $(LINUX_HEADERS_UNPACK_DIR)/.unpacked: $(DL_DIR)/$(LINUX_HEADERS_SOURCE)
> +       $(Q)$(call MESSAGE,"Extracting kernel headers")
>         rm -rf $(LINUX_HEADERS_DIR)
>         $(INSTALL) -d $(@D)
>         $(LINUX_HEADERS_CAT) $(DL_DIR)/$(LINUX_HEADERS_SOURCE) | \
> @@ -55,6 +56,7 @@ $(LINUX_HEADERS_UNPACK_DIR)/.unpacked: $(DL_DIR)/$(LINUX_HEADERS_SOURCE)
>         touch $@
>
>  $(LINUX_HEADERS_UNPACK_DIR)/.patched: $(LINUX_HEADERS_UNPACK_DIR)/.unpacked $(LINUX_HEADERS_DEPENDS)
> +       $(Q)$(call MESSAGE,"Patching kernel headers")
>         support/scripts/apply-patches.sh $(LINUX_HEADERS_UNPACK_DIR) toolchain/kernel-headers \
>                 linux-$(LINUX_HEADERS_VERSION)-\*.patch{,.gz,.bz2}
>  ifneq ($(KERNEL_HEADERS_PATCH_DIR),)
> @@ -64,6 +66,7 @@ endif
>         touch $@
>
>  $(LINUX_HEADERS_DIR)/.configured: $(LINUX_HEADERS_UNPACK_DIR)/.patched
> +       $(Q)$(call MESSAGE,"Installing kernel headers")
>         (cd $(LINUX_HEADERS_UNPACK_DIR); \
>          $(MAKE) ARCH=$(KERNEL_ARCH) \
>                 HOSTCC="$(HOSTCC)" HOSTCFLAGS="$(HOSTCFLAGS)" \
> --
> 1.7.2.5
>
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

Looks good to me

Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>
Arnout Vandecappelle - Jan. 20, 2013, 2:04 p.m.
On 01/17/13 00:41, Yann E. MORIN wrote:
> Thus, the failing step can be easily extracted by autobuilders,
> to ease with post-mortem analysis.
>
> Signed-off-by: "Yann E. MORIN"<yann.morin.1998@free.fr>

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Patch

diff --git a/toolchain/kernel-headers/kernel-headers.mk b/toolchain/kernel-headers/kernel-headers.mk
index 568c192..53c4a58 100644
--- a/toolchain/kernel-headers/kernel-headers.mk
+++ b/toolchain/kernel-headers/kernel-headers.mk
@@ -48,6 +48,7 @@  endif
 LINUX_HEADERS_DEPENDS:=
 
 $(LINUX_HEADERS_UNPACK_DIR)/.unpacked: $(DL_DIR)/$(LINUX_HEADERS_SOURCE)
+	$(Q)$(call MESSAGE,"Extracting kernel headers")
 	rm -rf $(LINUX_HEADERS_DIR)
 	$(INSTALL) -d $(@D)
 	$(LINUX_HEADERS_CAT) $(DL_DIR)/$(LINUX_HEADERS_SOURCE) | \
@@ -55,6 +56,7 @@  $(LINUX_HEADERS_UNPACK_DIR)/.unpacked: $(DL_DIR)/$(LINUX_HEADERS_SOURCE)
 	touch $@
 
 $(LINUX_HEADERS_UNPACK_DIR)/.patched: $(LINUX_HEADERS_UNPACK_DIR)/.unpacked $(LINUX_HEADERS_DEPENDS)
+	$(Q)$(call MESSAGE,"Patching kernel headers")
 	support/scripts/apply-patches.sh $(LINUX_HEADERS_UNPACK_DIR) toolchain/kernel-headers \
 		linux-$(LINUX_HEADERS_VERSION)-\*.patch{,.gz,.bz2}
 ifneq ($(KERNEL_HEADERS_PATCH_DIR),)
@@ -64,6 +66,7 @@  endif
 	touch $@
 
 $(LINUX_HEADERS_DIR)/.configured: $(LINUX_HEADERS_UNPACK_DIR)/.patched
+	$(Q)$(call MESSAGE,"Installing kernel headers")
 	(cd $(LINUX_HEADERS_UNPACK_DIR); \
 	 $(MAKE) ARCH=$(KERNEL_ARCH) \
 		HOSTCC="$(HOSTCC)" HOSTCFLAGS="$(HOSTCFLAGS)" \