Patchwork [U-Boot,5/7] Tegra114: Dalmore: Add DT files

login
register
mail settings
Submitter Tom Warren
Date Jan. 16, 2013, 9:14 p.m.
Message ID <1358370848-29469-6-git-send-email-twarren@nvidia.com>
Download mbox | patch
Permalink /patch/213062/
State Superseded
Delegated to: Tom Warren
Headers show

Comments

Tom Warren - Jan. 16, 2013, 9:14 p.m.
These are stripped down for bringup, They'll be filled out later
to match-up with the kernel DT contents, and/or as devices are
brought up (mmc, usb, spi, etc.).

Signed-off-by: Tom Warren <twarren@nvidia.com>
---
 arch/arm/dts/tegra114.dtsi            |    5 +++++
 board/nvidia/dts/tegra114-dalmore.dts |   13 +++++++++++++
 2 files changed, 18 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/dts/tegra114.dtsi
 create mode 100644 board/nvidia/dts/tegra114-dalmore.dts
Stephen Warren - Jan. 16, 2013, 10:47 p.m.
On 01/16/2013 02:14 PM, Tom Warren wrote:
> These are stripped down for bringup, They'll be filled out later
> to match-up with the kernel DT contents, and/or as devices are
> brought up (mmc, usb, spi, etc.).

> diff --git a/board/nvidia/dts/tegra114-dalmore.dts b/board/nvidia/dts/tegra114-dalmore.dts

> +	memory {
> +		device_type = "memory";
> +		reg = <0x80000000 0x40000000>;
> +	};

Indeed, that says just 1GB...
Tom Warren - Jan. 17, 2013, 5:58 p.m.
Stephen,

On Wed, Jan 16, 2013 at 3:47 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 01/16/2013 02:14 PM, Tom Warren wrote:
>> These are stripped down for bringup, They'll be filled out later
>> to match-up with the kernel DT contents, and/or as devices are
>> brought up (mmc, usb, spi, etc.).
>
>> diff --git a/board/nvidia/dts/tegra114-dalmore.dts b/board/nvidia/dts/tegra114-dalmore.dts
>
>> +     memory {
>> +             device_type = "memory";
>> +             reg = <0x80000000 0x40000000>;
>> +     };
>
> Indeed, that says just 1GB...
>

True, but that's what's in current Cardhu DTS, and Harmony, Seaboard,
and Ventana DTS files. Only Whistler has 0x20000000 (512MB).

How is this used, and how do we keep it in sync with what's really on
the board/in the ODMDATA field?

Tom
Stephen Warren - Jan. 17, 2013, 10:25 p.m.
On 01/17/2013 10:58 AM, Tom Warren wrote:
> Stephen,
> 
> On Wed, Jan 16, 2013 at 3:47 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>> On 01/16/2013 02:14 PM, Tom Warren wrote:
>>> These are stripped down for bringup, They'll be filled out later
>>> to match-up with the kernel DT contents, and/or as devices are
>>> brought up (mmc, usb, spi, etc.).
>>
>>> diff --git a/board/nvidia/dts/tegra114-dalmore.dts b/board/nvidia/dts/tegra114-dalmore.dts
>>
>>> +     memory {
>>> +             device_type = "memory";
>>> +             reg = <0x80000000 0x40000000>;
>>> +     };
>>
>> Indeed, that says just 1GB...
>>
> 
> True, but that's what's in current Cardhu DTS, and Harmony, Seaboard,
> and Ventana DTS files. Only Whistler has 0x20000000 (512MB).
> 
> How is this used, and how do we keep it in sync with what's really on
> the board/in the ODMDATA field?

I don't believe U-Boot uses that property from the DT. Probably the DT
isn't parsed early enough for it to be useful. But if we add it to the
.dts file, it may as well be correct even so. Or, perhaps we should just
remove it from the U-Boot DT since it isn't useful.
Tom Warren - Jan. 17, 2013, 10:58 p.m.
Stephen,

On Thu, Jan 17, 2013 at 3:25 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 01/17/2013 10:58 AM, Tom Warren wrote:
>> Stephen,
>>
>> On Wed, Jan 16, 2013 at 3:47 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>>> On 01/16/2013 02:14 PM, Tom Warren wrote:
>>>> These are stripped down for bringup, They'll be filled out later
>>>> to match-up with the kernel DT contents, and/or as devices are
>>>> brought up (mmc, usb, spi, etc.).
>>>
>>>> diff --git a/board/nvidia/dts/tegra114-dalmore.dts b/board/nvidia/dts/tegra114-dalmore.dts
>>>
>>>> +     memory {
>>>> +             device_type = "memory";
>>>> +             reg = <0x80000000 0x40000000>;
>>>> +     };
>>>
>>> Indeed, that says just 1GB...
>>>
>>
>> True, but that's what's in current Cardhu DTS, and Harmony, Seaboard,
>> and Ventana DTS files. Only Whistler has 0x20000000 (512MB).
>>
>> How is this used, and how do we keep it in sync with what's really on
>> the board/in the ODMDATA field?
>
> I don't believe U-Boot uses that property from the DT. Probably the DT
> isn't parsed early enough for it to be useful. But if we add it to the
> .dts file, it may as well be correct even so. Or, perhaps we should just
> remove it from the U-Boot DT since it isn't useful.

Another candidate for a clean-up pass patchset over all Tegra code.
For now, I'll bump it to 2GB for Dalmore (and Cardhu), since that's
what's on the sample boards.

Thanks,

Tom
Stephen Warren - Jan. 17, 2013, 11:11 p.m.
On 01/17/2013 03:58 PM, Tom Warren wrote:
> Stephen,
> 
> On Thu, Jan 17, 2013 at 3:25 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>> On 01/17/2013 10:58 AM, Tom Warren wrote:
>>> Stephen,
>>>
>>> On Wed, Jan 16, 2013 at 3:47 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>>>> On 01/16/2013 02:14 PM, Tom Warren wrote:
>>>>> These are stripped down for bringup, They'll be filled out later
>>>>> to match-up with the kernel DT contents, and/or as devices are
>>>>> brought up (mmc, usb, spi, etc.).
>>>>
>>>>> diff --git a/board/nvidia/dts/tegra114-dalmore.dts b/board/nvidia/dts/tegra114-dalmore.dts
>>>>
>>>>> +     memory {
>>>>> +             device_type = "memory";
>>>>> +             reg = <0x80000000 0x40000000>;
>>>>> +     };
>>>>
>>>> Indeed, that says just 1GB...
>>>>
>>>
>>> True, but that's what's in current Cardhu DTS, and Harmony, Seaboard,
>>> and Ventana DTS files. Only Whistler has 0x20000000 (512MB).
>>>
>>> How is this used, and how do we keep it in sync with what's really on
>>> the board/in the ODMDATA field?
>>
>> I don't believe U-Boot uses that property from the DT. Probably the DT
>> isn't parsed early enough for it to be useful. But if we add it to the
>> .dts file, it may as well be correct even so. Or, perhaps we should just
>> remove it from the U-Boot DT since it isn't useful.
> 
> Another candidate for a clean-up pass patchset over all Tegra code.
> For now, I'll bump it to 2GB for Dalmore (and Cardhu), since that's
> what's on the sample boards.

1GB would be safer for Cardhu; there are certainly very commonly used
Cardhu SKUs with only 1GB of RAM. I have one. In fact, I once heard that
most Linux-oriented Cardhu were 1GB and the 2GB devices were mostly used
for Windows development.
Tom Warren - Jan. 17, 2013, 11:29 p.m.
Well, it's at 1GB now, so I'll leave it as is.

Thanks.

On Thu, Jan 17, 2013 at 4:11 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 01/17/2013 03:58 PM, Tom Warren wrote:
>> Stephen,
>>
>> On Thu, Jan 17, 2013 at 3:25 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>>> On 01/17/2013 10:58 AM, Tom Warren wrote:
>>>> Stephen,
>>>>
>>>> On Wed, Jan 16, 2013 at 3:47 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>>>>> On 01/16/2013 02:14 PM, Tom Warren wrote:
>>>>>> These are stripped down for bringup, They'll be filled out later
>>>>>> to match-up with the kernel DT contents, and/or as devices are
>>>>>> brought up (mmc, usb, spi, etc.).
>>>>>
>>>>>> diff --git a/board/nvidia/dts/tegra114-dalmore.dts b/board/nvidia/dts/tegra114-dalmore.dts
>>>>>
>>>>>> +     memory {
>>>>>> +             device_type = "memory";
>>>>>> +             reg = <0x80000000 0x40000000>;
>>>>>> +     };
>>>>>
>>>>> Indeed, that says just 1GB...
>>>>>
>>>>
>>>> True, but that's what's in current Cardhu DTS, and Harmony, Seaboard,
>>>> and Ventana DTS files. Only Whistler has 0x20000000 (512MB).
>>>>
>>>> How is this used, and how do we keep it in sync with what's really on
>>>> the board/in the ODMDATA field?
>>>
>>> I don't believe U-Boot uses that property from the DT. Probably the DT
>>> isn't parsed early enough for it to be useful. But if we add it to the
>>> .dts file, it may as well be correct even so. Or, perhaps we should just
>>> remove it from the U-Boot DT since it isn't useful.
>>
>> Another candidate for a clean-up pass patchset over all Tegra code.
>> For now, I'll bump it to 2GB for Dalmore (and Cardhu), since that's
>> what's on the sample boards.
>
> 1GB would be safer for Cardhu; there are certainly very commonly used
> Cardhu SKUs with only 1GB of RAM. I have one. In fact, I once heard that
> most Linux-oriented Cardhu were 1GB and the 2GB devices were mostly used
> for Windows development.

Patch

diff --git a/arch/arm/dts/tegra114.dtsi b/arch/arm/dts/tegra114.dtsi
new file mode 100644
index 0000000..d06cd12
--- /dev/null
+++ b/arch/arm/dts/tegra114.dtsi
@@ -0,0 +1,5 @@ 
+/include/ "skeleton.dtsi"
+
+/ {
+	compatible = "nvidia,tegra114";
+};
diff --git a/board/nvidia/dts/tegra114-dalmore.dts b/board/nvidia/dts/tegra114-dalmore.dts
new file mode 100644
index 0000000..d108001
--- /dev/null
+++ b/board/nvidia/dts/tegra114-dalmore.dts
@@ -0,0 +1,13 @@ 
+/dts-v1/;
+
+/include/ ARCH_CPU_DTS
+
+/ {
+	model = "NVIDIA Dalmore";
+	compatible = "nvidia,dalmore", "nvidia,tegra114";
+
+	memory {
+		device_type = "memory";
+		reg = <0x80000000 0x40000000>;
+	};
+};