Patchwork [3/5] package/customize: remove

login
register
mail settings
Submitter Thomas Petazzoni
Date Jan. 16, 2013, 7:09 p.m.
Message ID <1358363393-29977-4-git-send-email-thomas.petazzoni@free-electrons.com>
Download mbox | patch
Permalink /patch/212990/
State Changes Requested
Headers show

Comments

Thomas Petazzoni - Jan. 16, 2013, 7:09 p.m.
This mechanism of root filesystem customization has been deprecated
since a long time, so let's remove it now.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/Config.in              |    1 -
 package/customize/Config.in    |    7 -------
 package/customize/customize.mk |   32 --------------------------------
 3 files changed, 40 deletions(-)
 delete mode 100644 package/customize/Config.in
 delete mode 100644 package/customize/customize.mk
 delete mode 100644 package/customize/source/.empty

diff --git a/package/customize/source/.empty b/package/customize/source/.empty
deleted file mode 100644
index e69de29..0000000
Arnout Vandecappelle - Jan. 19, 2013, 12:51 p.m.
On 16/01/13 20:09, Thomas Petazzoni wrote:
> This mechanism of root filesystem customization has been deprecated
> since a long time, so let's remove it now.
>
> Signed-off-by: Thomas Petazzoni<thomas.petazzoni@free-electrons.com>

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

  It can also be removed from pkg-stats.

  And maybe it should be added to Config.in.legacy?

  Regards,
  Arnout
Yann E. MORIN - Jan. 25, 2013, 6:35 p.m.
On Wednesday 16 January 2013 Thomas Petazzoni wrote:
> This mechanism of root filesystem customization has been deprecated
> since a long time, so let's remove it now.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

As Arnout suggested, it would be nice to add this to the legacy checks.
I'm afraid people who used that will be highly disapointed when they
see thir builds breaks without warning.

Otherwise, on the priniciple:
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

> ---
>  package/Config.in              |    1 -
>  package/customize/Config.in    |    7 -------
>  package/customize/customize.mk |   32 --------------------------------
>  3 files changed, 40 deletions(-)
>  delete mode 100644 package/customize/Config.in
>  delete mode 100644 package/customize/customize.mk
>  delete mode 100644 package/customize/source/.empty
> 
> diff --git a/package/Config.in b/package/Config.in
> index ba03b3c..5c78784 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1,7 +1,6 @@
>  menu "Package Selection for the target"
>  
>  source "package/busybox/Config.in"
> -source "package/customize/Config.in"
>  
>  # Audio and video applications
>  source "package/multimedia/Config.in"
> diff --git a/package/customize/Config.in b/package/customize/Config.in
> deleted file mode 100644
> index 8f8aaa2..0000000
> --- a/package/customize/Config.in
> +++ /dev/null
> @@ -1,7 +0,0 @@
> -config BR2_PACKAGE_CUSTOMIZE
> -	bool "customize"
> -	depends on BR2_DEPRECATED
> -	help
> -	  Add custom stuff to your buildroot.
> -
> -	  (edit package/customize/customize.mk)
> diff --git a/package/customize/customize.mk b/package/customize/customize.mk
> deleted file mode 100644
> index d2b8518..0000000
> --- a/package/customize/customize.mk
> +++ /dev/null
> @@ -1,32 +0,0 @@
> -#############################################################
> -#
> -# Any custom stuff you feel like doing....
> -#
> -#############################################################
> -CUST_DIR:=package/customize/source
> -
> -$(BUILD_DIR)/.customize:
> -	rm -f $(BUILD_DIR)/series
> -	(cd $(CUST_DIR); \
> -	 /bin/ls -d * > $(BUILD_DIR)/series || \
> -	 touch $(BUILD_DIR)/series )
> -	for f in `cat $(BUILD_DIR)/series`; do \
> -		cp -af $(CUST_DIR)/$$f $(TARGET_DIR); \
> -	done
> -	rm -f $(BUILD_DIR)/series
> -	touch $@
> -
> -customize: $(BUILD_DIR)/.customize
> -
> -customize-clean:
> -	rm -f $(BUILD_DIR)/.customize
> -
> -.PHONY: customize
> -#############################################################
> -#
> -# Toplevel Makefile options
> -#
> -#############################################################
> -ifeq ($(BR2_PACKAGE_CUSTOMIZE),y)
> -TARGETS+=customize
> -endif
> diff --git a/package/customize/source/.empty b/package/customize/source/.empty
> deleted file mode 100644
> index e69de29..0000000
> -- 
> 1.7.9.5
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 
>
Luca Ceresoli - Jan. 29, 2013, 4:27 p.m.
Thomas Petazzoni wrote:
> This mechanism of root filesystem customization has been deprecated
> since a long time, so let's remove it now.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

With Arnout's suggestions applied:
Acked-by: Luca Ceresoli <luca@lucaceresoli.net>

Patch

diff --git a/package/Config.in b/package/Config.in
index ba03b3c..5c78784 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1,7 +1,6 @@ 
 menu "Package Selection for the target"
 
 source "package/busybox/Config.in"
-source "package/customize/Config.in"
 
 # Audio and video applications
 source "package/multimedia/Config.in"
diff --git a/package/customize/Config.in b/package/customize/Config.in
deleted file mode 100644
index 8f8aaa2..0000000
--- a/package/customize/Config.in
+++ /dev/null
@@ -1,7 +0,0 @@ 
-config BR2_PACKAGE_CUSTOMIZE
-	bool "customize"
-	depends on BR2_DEPRECATED
-	help
-	  Add custom stuff to your buildroot.
-
-	  (edit package/customize/customize.mk)
diff --git a/package/customize/customize.mk b/package/customize/customize.mk
deleted file mode 100644
index d2b8518..0000000
--- a/package/customize/customize.mk
+++ /dev/null
@@ -1,32 +0,0 @@ 
-#############################################################
-#
-# Any custom stuff you feel like doing....
-#
-#############################################################
-CUST_DIR:=package/customize/source
-
-$(BUILD_DIR)/.customize:
-	rm -f $(BUILD_DIR)/series
-	(cd $(CUST_DIR); \
-	 /bin/ls -d * > $(BUILD_DIR)/series || \
-	 touch $(BUILD_DIR)/series )
-	for f in `cat $(BUILD_DIR)/series`; do \
-		cp -af $(CUST_DIR)/$$f $(TARGET_DIR); \
-	done
-	rm -f $(BUILD_DIR)/series
-	touch $@
-
-customize: $(BUILD_DIR)/.customize
-
-customize-clean:
-	rm -f $(BUILD_DIR)/.customize
-
-.PHONY: customize
-#############################################################
-#
-# Toplevel Makefile options
-#
-#############################################################
-ifeq ($(BR2_PACKAGE_CUSTOMIZE),y)
-TARGETS+=customize
-endif