Patchwork [RFC,V1,10/12] qerror: Add QERR_DEVICE_NOT_DEDUPLICATED.

login
register
mail settings
Submitter Benoît Canet
Date Jan. 16, 2013, 4:25 p.m.
Message ID <1358353518-5421-11-git-send-email-benoit@irqsave.net>
Download mbox | patch
Permalink /patch/212960/
State New
Headers show

Comments

Benoît Canet - Jan. 16, 2013, 4:25 p.m.
---
 include/qapi/qmp/qerror.h |    3 +++
 1 file changed, 3 insertions(+)
Eric Blake - Jan. 16, 2013, 11 p.m.
On 01/16/2013 09:25 AM, Benoît Canet wrote:
> ---
>  include/qapi/qmp/qerror.h |    3 +++
>  1 file changed, 3 insertions(+)

You don't want this patch; instead, code in later patches that currently
uses
 error_set(errp, QERR_DEVICE_NOT_DEDUPLICATED,
    bdrv_get_device_name(bs));
should instead call
 error_setg(errp, "Device '%s' doesn't support deduplication",
    bdrv_get_device_name(bs));

Patch

diff --git a/include/qapi/qmp/qerror.h b/include/qapi/qmp/qerror.h
index 6c0a18d..3f99c8c 100644
--- a/include/qapi/qmp/qerror.h
+++ b/include/qapi/qmp/qerror.h
@@ -108,6 +108,9 @@  void assert_no_error(Error *err);
 #define QERR_DEVICE_NOT_ACTIVE \
     ERROR_CLASS_DEVICE_NOT_ACTIVE, "Device '%s' has not been activated"
 
+#define QERR_DEVICE_NOT_DEDUPLICATED \
+    ERROR_CLASS_GENERIC_ERROR, "Device '%s' doesn't support deduplication"
+
 #define QERR_DEVICE_NOT_ENCRYPTED \
     ERROR_CLASS_GENERIC_ERROR, "Device '%s' is not encrypted"