From patchwork Wed Jan 16 17:38:40 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Weil X-Patchwork-Id: 212871 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 00C6F2C0091 for ; Thu, 17 Jan 2013 04:38:57 +1100 (EST) Received: from localhost ([::1]:53938 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvWwx-0000lV-0b for incoming@patchwork.ozlabs.org; Wed, 16 Jan 2013 12:38:55 -0500 Received: from eggs.gnu.org ([208.118.235.92]:59484) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvWwo-0000jp-3F for qemu-devel@nongnu.org; Wed, 16 Jan 2013 12:38:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TvWwl-0002f4-8a for qemu-devel@nongnu.org; Wed, 16 Jan 2013 12:38:45 -0500 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:35264) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvWwk-0002es-WF for qemu-devel@nongnu.org; Wed, 16 Jan 2013 12:38:43 -0500 Received: from localhost (v220110690675601.yourvserver.net.local [127.0.0.1]) by v220110690675601.yourvserver.net (Postfix) with ESMTP id 735587280056; Wed, 16 Jan 2013 18:38:42 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at weilnetz.de Received: from v220110690675601.yourvserver.net ([127.0.0.1]) by localhost (v220110690675601.yourvserver.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gv0zI0gcH8t9; Wed, 16 Jan 2013 18:38:42 +0100 (CET) Received: by v220110690675601.yourvserver.net (Postfix, from userid 1000) id 20C227280057; Wed, 16 Jan 2013 18:38:42 +0100 (CET) From: Stefan Weil To: Anthony Liguori Date: Wed, 16 Jan 2013 18:38:40 +0100 Message-Id: <1358357920-7543-1-git-send-email-sw@weilnetz.de> X-Mailer: git-send-email 1.7.10.4 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 78.47.199.172 Cc: Stefan Weil , qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH] ui: Replace non-portable asprintf by g_strdup_printf X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Stefan Weil --- This code is untested because I don't have a Mac available. Portability is unimportant here (it's only for cocoa), but I replaced asprintf nevertheless for the sake of uniformity of QEMU's code. Regards, Stefan Weil ui/cocoa.m | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 3bf1c6e..754b95c 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -813,9 +813,9 @@ QemuCocoaView *cocoaView; [sheet close]; - asprintf(&argv[0], "%s", bin); - asprintf(&argv[1], "-hda"); - asprintf(&argv[2], "%s", img); + argv[0] = g_strdup_printf("%s", bin); + argv[1] = g_strdup_printf("-hda"); + argv[2] = g_strdup_printf("%s", img); printf("Using argc %d argv %s -hda %s\n", 3, bin, img);