Patchwork [121/222] kbuild: Do not remove vmlinux when cleaning external module

mail settings
Submitter Herton Ronaldo Krzesinski
Date Jan. 16, 2013, 3:55 p.m.
Message ID <>
Download mbox | patch
Permalink /patch/212698/
State New
Headers show


Herton Ronaldo Krzesinski - Jan. 16, 2013, 3:55 p.m. -stable review patch.  If anyone has any objections, please let me know.


From: Pawel Moll <>

commit bd1ee804af8bdf2fd5131234330615f8aecbd9ed upstream.

Since commit 1f2bfbd00e466ff3489b2ca5cc75b1cccd14c123 "kbuild:
link of vmlinux moved to a script" make clean with M=<dir>
argument (so cleaning external module) removes vmlinux, and couple of other files from the *main* kernel
build directory! This not what was happening before and almost
certainly not what one would expect.

This patch moves makes the clean target of the script called
only when !KBUILD_EXTMOD.

Signed-off-by: Pawel Moll <>
Signed-off-by: Michal Marek <>
Signed-off-by: Herton Ronaldo Krzesinski <>
 Makefile |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)


diff --git a/Makefile b/Makefile
index de1e58b..d253746 100644
--- a/Makefile
+++ b/Makefile
@@ -1003,11 +1003,14 @@  clean: rm-dirs  := $(CLEAN_DIRS)
 clean: rm-files := $(CLEAN_FILES)
 clean-dirs      := $(addprefix _clean_, . $(vmlinux-alldirs) Documentation samples)
-PHONY += $(clean-dirs) clean archclean
+PHONY += $(clean-dirs) clean archclean vmlinuxclean
 	$(Q)$(MAKE) $(clean)=$(patsubst _clean_%,%,$@)
-clean: archclean
+	$(Q)$(CONFIG_SHELL) $(srctree)/scripts/ clean
+clean: archclean vmlinuxclean
 # mrproper - Delete all generated files, including .config
@@ -1234,7 +1237,6 @@  scripts: ;
 clean: $(clean-dirs)
-	$(Q)$(CONFIG_SHELL) $(srctree)/scripts/ clean
 	$(call cmd,rmdirs)
 	$(call cmd,rmfiles)