From patchwork Wed Jan 16 14:36:37 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Armbruster X-Patchwork-Id: 212559 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id BAF9B2C0096 for ; Thu, 17 Jan 2013 02:13:12 +1100 (EST) Received: from localhost ([::1]:50059 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvU7P-0001yI-OG for incoming@patchwork.ozlabs.org; Wed, 16 Jan 2013 09:37:31 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41025) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvU6g-0000DJ-N0 for qemu-devel@nongnu.org; Wed, 16 Jan 2013 09:36:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TvU6c-000264-71 for qemu-devel@nongnu.org; Wed, 16 Jan 2013 09:36:46 -0500 Received: from oxygen.pond.sub.org ([2a01:4f8:121:10e4::3]:41693) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvU6b-00025I-U2; Wed, 16 Jan 2013 09:36:42 -0500 Received: from blackfin.pond.sub.org (p5B32B5E9.dip.t-dialin.net [91.50.181.233]) by oxygen.pond.sub.org (Postfix) with ESMTPA id CDF90A2C77; Wed, 16 Jan 2013 15:36:39 +0100 (CET) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 07DB6200A9; Wed, 16 Jan 2013 15:36:39 +0100 (CET) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Wed, 16 Jan 2013 15:36:37 +0100 Message-Id: <1358346998-26328-11-git-send-email-armbru@redhat.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1358346998-26328-1-git-send-email-armbru@redhat.com> References: <1358346998-26328-1-git-send-email-armbru@redhat.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a01:4f8:121:10e4::3 Cc: qemu-trivial@nongnu.org Subject: [Qemu-devel] [PATCH 10/11] qapi: Fix unchecked strdup() by converting to g_strdup() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Note that we already free with g_free(). Signed-off-by: Markus Armbruster --- qapi/qmp-registry.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/qmp-registry.c b/qapi/qmp-registry.c index 70cdbca..28bbbe8 100644 --- a/qapi/qmp-registry.c +++ b/qapi/qmp-registry.c @@ -92,7 +92,7 @@ char **qmp_get_command_list(void) list_head = list = g_malloc0(count * sizeof(char *)); QTAILQ_FOREACH(cmd, &qmp_commands, node) { - *list = strdup(cmd->name); + *list = g_strdup(cmd->name); list++; }