From patchwork Wed Jan 16 14:36:32 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Armbruster X-Patchwork-Id: 212540 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 5AAD92C0092 for ; Thu, 17 Jan 2013 01:40:52 +1100 (EST) Received: from localhost ([::1]:50147 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvU7V-00020w-8y for incoming@patchwork.ozlabs.org; Wed, 16 Jan 2013 09:37:37 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41009) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvU6f-0000D3-5t for qemu-devel@nongnu.org; Wed, 16 Jan 2013 09:36:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TvU6c-00025h-28 for qemu-devel@nongnu.org; Wed, 16 Jan 2013 09:36:45 -0500 Received: from oxygen.pond.sub.org ([2a01:4f8:121:10e4::3]:41687) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvU6b-000259-QO; Wed, 16 Jan 2013 09:36:41 -0500 Received: from blackfin.pond.sub.org (p5B32B5E9.dip.t-dialin.net [91.50.181.233]) by oxygen.pond.sub.org (Postfix) with ESMTPA id 8F8359FF74; Wed, 16 Jan 2013 15:36:39 +0100 (CET) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id A83A5200AC; Wed, 16 Jan 2013 15:36:38 +0100 (CET) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Wed, 16 Jan 2013 15:36:32 +0100 Message-Id: <1358346998-26328-6-git-send-email-armbru@redhat.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1358346998-26328-1-git-send-email-armbru@redhat.com> References: <1358346998-26328-1-git-send-email-armbru@redhat.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a01:4f8:121:10e4::3 Cc: qemu-trivial@nongnu.org Subject: [Qemu-devel] [PATCH 05/11] spice: Fix unchecked strdup() by converting to g_strdup() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Markus Armbruster --- ui/spice-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index 3f2c565..bcc4199 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -848,8 +848,8 @@ static int qemu_spice_set_ticket(bool fail_if_conn, bool disconnect_if_conn) int qemu_spice_set_passwd(const char *passwd, bool fail_if_conn, bool disconnect_if_conn) { - free(auth_passwd); - auth_passwd = strdup(passwd); + g_free(auth_passwd); + auth_passwd = g_strdup(passwd); return qemu_spice_set_ticket(fail_if_conn, disconnect_if_conn); }