Patchwork [v4,2/2] mtd/uclinux: add a comment about why uclinux_ram_map must not be static

login
register
mail settings
Submitter Uwe Kleine-König
Date Jan. 16, 2013, 2:36 p.m.
Message ID <1358347016-507-2-git-send-email-u.kleine-koenig@pengutronix.de>
Download mbox | patch
Permalink /patch/212537/
State Accepted
Commit 44fe63fc0fcbfef65b5a8c015abb4dbbbcc90f23
Headers show

Comments

Uwe Kleine-König - Jan. 16, 2013, 2:36 p.m.
I was (at least) the second person trying to fix a warning by sparse, so
document in the code why this is a bad idea and add an extern declaration to
make sparse happy.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Mike Frysinger <vapier@gentoo.org>
Acked-by: Greg Ungerer <gerg@uclinux.org>
---
No changes between v3 and v4.

Changes since v2,
id:1350027693-19528-2-git-send-email-u.kleine-koenig@pengutronix.de:

 - note in the commit log that an extern declaration was added for sparse

Changes since v1:

 - new patch
---
 drivers/mtd/maps/uclinux.c |    6 ++++++
 1 file changed, 6 insertions(+)

Patch

diff --git a/drivers/mtd/maps/uclinux.c b/drivers/mtd/maps/uclinux.c
index f56d0aa..c1af83d 100644
--- a/drivers/mtd/maps/uclinux.c
+++ b/drivers/mtd/maps/uclinux.c
@@ -29,6 +29,12 @@ 
 #define MAP_NAME "ram"
 #endif
 
+/*
+ * Blackfin uses uclinux_ram_map during startup, so it must not be static.
+ * Provide a dummy declaration to make sparse happy.
+ */
+extern struct map_info uclinux_ram_map;
+
 struct map_info uclinux_ram_map = {
 	.name = MAP_NAME,
 	.size = 0,