From patchwork Wed Jan 16 14:36:31 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Armbruster X-Patchwork-Id: 212531 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 596AB2C008D for ; Thu, 17 Jan 2013 01:37:02 +1100 (EST) Received: from localhost ([::1]:47026 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvU6u-0000Eg-Bt for incoming@patchwork.ozlabs.org; Wed, 16 Jan 2013 09:37:00 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvU6d-0000Cn-TP for qemu-devel@nongnu.org; Wed, 16 Jan 2013 09:36:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TvU6b-00024q-Fa for qemu-devel@nongnu.org; Wed, 16 Jan 2013 09:36:43 -0500 Received: from oxygen.pond.sub.org ([2a01:4f8:121:10e4::3]:41686) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvU6b-00023S-7R; Wed, 16 Jan 2013 09:36:41 -0500 Received: from blackfin.pond.sub.org (p5B32B5E9.dip.t-dialin.net [91.50.181.233]) by oxygen.pond.sub.org (Postfix) with ESMTPA id 56D5D9FE7B; Wed, 16 Jan 2013 15:36:39 +0100 (CET) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 9D9BD200AD; Wed, 16 Jan 2013 15:36:38 +0100 (CET) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Wed, 16 Jan 2013 15:36:31 +0100 Message-Id: <1358346998-26328-5-git-send-email-armbru@redhat.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1358346998-26328-1-git-send-email-armbru@redhat.com> References: <1358346998-26328-1-git-send-email-armbru@redhat.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a01:4f8:121:10e4::3 Cc: qemu-trivial@nongnu.org Subject: [Qemu-devel] [PATCH 04/11] readline: Fix unchecked strdup() by converting to g_strdup() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Markus Armbruster --- readline.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/readline.c b/readline.c index a0c9638..d6e04d4 100644 --- a/readline.c +++ b/readline.c @@ -247,14 +247,14 @@ static void readline_hist_add(ReadLineState *rs, const char *cmdline) } if (idx == READLINE_MAX_CMDS) { /* Need to get one free slot */ - free(rs->history[0]); + g_free(rs->history[0]); memmove(rs->history, &rs->history[1], (READLINE_MAX_CMDS - 1) * sizeof(char *)); rs->history[READLINE_MAX_CMDS - 1] = NULL; idx = READLINE_MAX_CMDS - 1; } if (new_entry == NULL) - new_entry = strdup(cmdline); + new_entry = g_strdup(cmdline); rs->history[idx] = new_entry; rs->hist_entry = -1; }