Patchwork ipv6: do not create neighbor entries for local delivery

login
register
mail settings
Submitter Marcelo Leitner
Date Jan. 16, 2013, 1:31 p.m.
Message ID <50F6ABCA.4020804@redhat.com>
Download mbox | patch
Permalink /patch/212515/
State Rejected
Delegated to: David Miller
Headers show

Comments

Marcelo Leitner - Jan. 16, 2013, 1:31 p.m.
They will be created at output, if ever needed. This avoids creating
empty neighbor entries when TPROXYing/Forwarding packets for addresses
that are not even directly reachable.

Note that IPv4 already handles it this way. No neighbor entries are
created for local input.

Tested by myself and customer.

Signed-off-By: Marcelo Ricardo Leitner <mleitner@redhat.com>
---
  net/ipv6/route.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
David Miller - Jan. 16, 2013, 9:28 p.m.
From: Marcelo Ricardo Leitner <mleitner@redhat.com>
Date: Wed, 16 Jan 2013 11:31:54 -0200

> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> index
> 7c34c01b515b7ac370f8021ba6f5ec4c654e9e41..b63e33bcbdfbc1bd78af0b98ffc2d211805214ea
> 100644

Patch corrupted by your email client.

Note also that YOSHIFUJI Hideaki's patches to remove the cached neighbour
entirely from ipv6 routes will have the same effect, so your patch won't
be needed.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Marcelo Leitner - Jan. 17, 2013, 11:17 a.m.
Em 16-01-2013 19:28, David Miller escreveu:
> From: Marcelo Ricardo Leitner <mleitner@redhat.com>
> Date: Wed, 16 Jan 2013 11:31:54 -0200
>
>> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
>> index
>> 7c34c01b515b7ac370f8021ba6f5ec4c654e9e41..b63e33bcbdfbc1bd78af0b98ffc2d211805214ea
>> 100644
>
> Patch corrupted by your email client.

Doh, really sorry about that.

> Note also that YOSHIFUJI Hideaki's patches to remove the cached neighbour
> entirely from ipv6 routes will have the same effect, so your patch won't
> be needed.

Yes but seems it needs some time yet. Mind if I submit it again (right 
this time)?

Thanks,
Marcelo.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jiri Pirko - Jan. 29, 2013, 10:53 a.m.
Wed, Jan 16, 2013 at 10:28:13PM CET, davem@davemloft.net wrote:
>From: Marcelo Ricardo Leitner <mleitner@redhat.com>
>Date: Wed, 16 Jan 2013 11:31:54 -0200
>
>> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
>> index
>> 7c34c01b515b7ac370f8021ba6f5ec4c654e9e41..b63e33bcbdfbc1bd78af0b98ffc2d211805214ea
>> 100644
>
>Patch corrupted by your email client.
>
>Note also that YOSHIFUJI Hideaki's patches to remove the cached neighbour
>entirely from ipv6 routes will have the same effect, so your patch won't
>be needed.

Dave, wouldn't this patch be suitable candidate for -net (/-stable) ?

I can repost this properly.

Thanks, Jiri



>--
>To unsubscribe from this list: send the line "unsubscribe netdev" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Jan. 29, 2013, 9:10 p.m.
From: Jiri Pirko <jiri@resnulli.us>
Date: Tue, 29 Jan 2013 11:53:36 +0100

> Wed, Jan 16, 2013 at 10:28:13PM CET, davem@davemloft.net wrote:
>>From: Marcelo Ricardo Leitner <mleitner@redhat.com>
>>Date: Wed, 16 Jan 2013 11:31:54 -0200
>>
>>> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
>>> index
>>> 7c34c01b515b7ac370f8021ba6f5ec4c654e9e41..b63e33bcbdfbc1bd78af0b98ffc2d211805214ea
>>> 100644
>>
>>Patch corrupted by your email client.
>>
>>Note also that YOSHIFUJI Hideaki's patches to remove the cached neighbour
>>entirely from ipv6 routes will have the same effect, so your patch won't
>>be needed.
> 
> Dave, wouldn't this patch be suitable candidate for -net (/-stable) ?
> 
> I can repost this properly.

Ok, please repost, thanks Jiri.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 
7c34c01b515b7ac370f8021ba6f5ec4c654e9e41..b63e33bcbdfbc1bd78af0b98ffc2d211805214ea 
100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -921,7 +921,7 @@  restart:
  	dst_hold(&rt->dst);
  	read_unlock_bh(&table->tb6_lock);
-	if (!rt->n && !(rt->rt6i_flags & RTF_NONEXTHOP))
+	if (!rt->n && !(rt->rt6i_flags & (RTF_NONEXTHOP|RTF_LOCAL)))
  		nrt = rt6_alloc_cow(rt, &fl6->daddr, &fl6->saddr);
  	else if (!(rt->dst.flags & DST_HOST))
  		nrt = rt6_alloc_clone(rt, &fl6->daddr);
-- 
1.7.11.7