Patchwork [2/2] proxychains-ng: copy proxychains.conf to target dir

login
register
mail settings
Submitter Stefan Fröberg
Date Jan. 16, 2013, 11:54 a.m.
Message ID <1358337261-13260-1-git-send-email-stefan.froberg@petroprogram.com>
Download mbox | patch
Permalink /patch/212494/
State Superseded
Headers show

Comments

Stefan Fröberg - Jan. 16, 2013, 11:54 a.m.
Signed-off-by: Stefan Fröberg <stefan.froberg@petroprogram.com>
---
 package/proxychains-ng/proxychains-ng.mk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Peter Korsgaard - Jan. 16, 2013, 12:20 p.m.
>>>>> "Stefan" == Stefan Fröberg <stefan.froberg@petroprogram.com> writes:

Committed, thanks.

2 nitpicks: It's a bit confusing to number a single patch as 2/2 - v2 of
a patch is normally called PATCHv2 or similar.

Secondly, we try to keep lines below 80 chars, so I've wrapped the
install line.
Peter Korsgaard - Jan. 16, 2013, 12:24 p.m.
>>>>> "Peter" == Peter Korsgaard <jacmet@uclibc.org> writes:

>>>>> "Stefan" == Stefan Fröberg <stefan.froberg@petroprogram.com> writes:
 Peter> Committed, thanks.

 Peter> 2 nitpicks: It's a bit confusing to number a single patch as 2/2 - v2 of
 Peter> a patch is normally called PATCHv2 or similar.

 Peter> Secondly, we try to keep lines below 80 chars, so I've wrapped the
 Peter> install line.

Ups, got sent too soon - You also sent this patch as a change relative
to the previous patch, but I haven't applied your earlier patch so you
should send it relative to trunk instead.
Stefan Fröberg - Jan. 16, 2013, 12:27 p.m.
16.1.2013 14:20, Peter Korsgaard kirjoitti:
>>>>>> "Stefan" == Stefan Fröberg <stefan.froberg@petroprogram.com> writes:
> Committed, thanks.
>
> 2 nitpicks: It's a bit confusing to number a single patch as 2/2 - v2 of
> a patch is normally called PATCHv2 or similar.

Ok, sorry about that too.

> Secondly, we try to keep lines below 80 chars, so I've wrapped the
> install line.
>

Okay.
I use nano editor for doing my coding stuff because it's fast & simple.
How can I force it to automatically wrap in 80 chars ?

Thanks!

Stefan
Peter Korsgaard - Jan. 16, 2013, 12:33 p.m.
>>>>> "Stefan" == Stefan Fröberg <stefan.froberg@petroprogram.com> writes:

Hi,

 Stefan> Okay.
 Stefan> I use nano editor for doing my coding stuff because it's fast &
 Stefan> simple.  How can I force it to automatically wrap in 80 chars ?

Sorry, I don't use nano so I don't know.

Patch

diff --git a/package/proxychains-ng/proxychains-ng.mk b/package/proxychains-ng/proxychains-ng.mk
index 70d35b6..2d6e036 100644
--- a/package/proxychains-ng/proxychains-ng.mk
+++ b/package/proxychains-ng/proxychains-ng.mk
@@ -8,7 +8,7 @@  PROXYCHAINS_NG_SOURCE = proxychains-$(PROXYCHAINS_NG_VERSION).tar.bz2
 PROXYCHAINS_NG_SITE = http://downloads.sourceforge.net/project/proxychains-ng
 
 define PROXYCHAINS_NG_POST_INSTALL_TARGET
-	$(INSTALL) -m 755 $(@D)/src/proxychains.conf $(TARGET_DIR)/etc
+	$(INSTALL) -m 644 -D $(@D)/src/proxychains.conf $(TARGET_DIR)/etc/proxychains.conf
 endef
 
 PROXYCHAINS_NG_POST_INSTALL_TARGET_HOOKS += PROXYCHAINS_NG_POST_INSTALL_TARGET