Patchwork [U-Boot,V5,REPOST,4/7] ARM: rpi_b: disable rpi_b dcache explicitly

login
register
mail settings
Submitter Stephen Warren
Date Jan. 16, 2013, 2:26 a.m.
Message ID <1358303219-17503-4-git-send-email-swarren@wwwdotorg.org>
Download mbox | patch
Permalink /patch/212376/
State Superseded
Delegated to: Albert ARIBAUD
Headers show

Comments

Stephen Warren - Jan. 16, 2013, 2:26 a.m.
There appears to be no implementation of flush_dcache_range() for
ARM1176, so explicitly disable dcache support to avoid references to
that function from the LCD core in the next patch. This was presumably
not noticed before simply because no drivers for the rpi_b were
attempting DMA.

Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
---
v5: No change; merged patch series.
v4: New patch.
---
 include/configs/rpi_b.h |    1 +
 1 file changed, 1 insertion(+)
Albert ARIBAUD - March 20, 2013, 3:31 p.m.
Hi Stephen,

On Tue, 15 Jan 2013 19:26:56 -0700, Stephen Warren
<swarren@wwwdotorg.org> wrote:

> There appears to be no implementation of flush_dcache_range() for
> ARM1176, so explicitly disable dcache support to avoid references to
> that function from the LCD core in the next patch. This was presumably
> not noticed before simply because no drivers for the rpi_b were
> attempting DMA.
> 
> Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
> ---
> v5: No change; merged patch series.
> v4: New patch.
> ---
>  include/configs/rpi_b.h |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/configs/rpi_b.h b/include/configs/rpi_b.h
> index cf62e45..5db31f5 100644
> --- a/include/configs/rpi_b.h
> +++ b/include/configs/rpi_b.h
> @@ -23,6 +23,7 @@
>  #define CONFIG_ARM1176
>  #define CONFIG_BCM2835
>  #define CONFIG_ARCH_CPU_INIT
> +#define CONFIG_SYS_DCACHE_OFF
>  /*
>   * 2835 is a SKU in a series for which the 2708 is the first or primary SoC,
>   * so 2708 has historically been used rather than a dedicated 2835 ID.

Applied to u-boot-arm/master, thanks!

Amicalement,

Patch

diff --git a/include/configs/rpi_b.h b/include/configs/rpi_b.h
index cf62e45..5db31f5 100644
--- a/include/configs/rpi_b.h
+++ b/include/configs/rpi_b.h
@@ -23,6 +23,7 @@ 
 #define CONFIG_ARM1176
 #define CONFIG_BCM2835
 #define CONFIG_ARCH_CPU_INIT
+#define CONFIG_SYS_DCACHE_OFF
 /*
  * 2835 is a SKU in a series for which the 2708 is the first or primary SoC,
  * so 2708 has historically been used rather than a dedicated 2835 ID.