Patchwork [Qemu-trivial] configure: silencing pkg-config's check for curses

login
register
mail settings
Submitter Vadim Evard
Date Jan. 15, 2013, 11:52 p.m.
Message ID <50F5EBDA.2040208@gmail.com>
Download mbox | patch
Permalink /patch/212353/
State New
Headers show

Comments

Vadim Evard - Jan. 15, 2013, 11:52 p.m.
From d10856f3b1d893b5d3c6ab213eb921d0a24e7766 Mon Sep 17 00:00:00 2001
From: Vadim Evard <v.e.evard@gmail.com>
Date: Wed, 16 Jan 2013 03:45:44 +0400
Subject: [PATCH] configure: silencing pkg-config's check for curses

---
 configure |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Stefan Hajnoczi - Jan. 16, 2013, 9:27 a.m.
On Wed, Jan 16, 2013 at 03:52:58AM +0400, Vadim Evard wrote:
> From d10856f3b1d893b5d3c6ab213eb921d0a24e7766 Mon Sep 17 00:00:00 2001
> From: Vadim Evard <v.e.evard@gmail.com>
> Date: Wed, 16 Jan 2013 03:45:44 +0400
> Subject: [PATCH] configure: silencing pkg-config's check for curses
> 
> ---
>  configure |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Probably best if Anthony or another qemu.git committer applies this
straight away instead of waiting for the next qemu-trivial pull request.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Anthony Liguori - Jan. 16, 2013, 2:54 p.m.
Vadim Evard <v.e.evard@gmail.com> writes:

>>From d10856f3b1d893b5d3c6ab213eb921d0a24e7766 Mon Sep 17 00:00:00 2001
> From: Vadim Evard <v.e.evard@gmail.com>
> Date: Wed, 16 Jan 2013 03:45:44 +0400
> Subject: [PATCH] configure: silencing pkg-config's check for curses


This is fubar above and it's missing a Signed-off-by.  Please CC me when
you send out a new version that fixes this.

Regards,

Anthony Liguori

>
> ---
>  configure |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 4ebb60d..6211db9 100755
> --- a/configure
> +++ b/configure
> @@ -2039,7 +2039,7 @@ fi
>  if test "$mingw32" = "yes" ; then
>      curses_list="-lpdcurses"
>  else
> -    curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses)"
> +    curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses 2>/dev/null)"
>  fi
>  
>  if test "$curses" != "no" ; then
> -- 
> 1.7.10.4

Patch

diff --git a/configure b/configure
index 4ebb60d..6211db9 100755
--- a/configure
+++ b/configure
@@ -2039,7 +2039,7 @@  fi
 if test "$mingw32" = "yes" ; then
     curses_list="-lpdcurses"
 else
-    curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses)"
+    curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses 2>/dev/null)"
 fi
 
 if test "$curses" != "no" ; then