Patchwork [3.5.y.z,extended,stable] Patch "NFS4: nfs4_opendata_access should return errno" has been added to staging queue

mail settings
Submitter Herton Ronaldo Krzesinski
Date Jan. 15, 2013, 10:21 p.m.
Message ID <>
Download mbox | patch
Permalink /patch/212329/
State New
Headers show


Herton Ronaldo Krzesinski - Jan. 15, 2013, 10:21 p.m.
This is a note to let you know that I have just added a patch titled

    NFS4: nfs4_opendata_access should return errno

to the linux-3.5.y-queue branch of the 3.5.y.z extended stable tree 
which can be found at:;a=shortlog;h=refs/heads/linux-3.5.y-queue

If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.5.y.z tree, see



From b88decc89a681559f9cf2deba7990b6dd74b369b Mon Sep 17 00:00:00 2001
From: Weston Andros Adamson <>
Date: Fri, 2 Nov 2012 18:00:56 -0400
Subject: [PATCH] NFS4: nfs4_opendata_access should return errno

commit 998f40b550f257e436485291802fa938e4cf580f upstream.

Return errno - not an NFS4ERR_. This worked because NFS4ERR_ACCESS == EACCES.

Signed-off-by: Weston Andros Adamson <>
Signed-off-by: Trond Myklebust <>
Signed-off-by: Herton Ronaldo Krzesinski <>
 fs/nfs/nfs4proc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index 6bc11de..fa3fbd1 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -1683,7 +1683,7 @@  static int nfs4_opendata_access(struct rpc_cred *cred,

 	/* even though OPEN succeeded, access is denied. Close the file */
 	nfs4_close_state(state, fmode);
-	return -NFS4ERR_ACCESS;
+	return -EACCES;