Patchwork [PULL,for-1.4,v2] Memory API ioport cleanups

login
register
mail settings
Submitter Andreas Färber
Date Jan. 15, 2013, 6:47 p.m.
Message ID <1358275677-20590-1-git-send-email-afaerber@suse.de>
Download mbox
Permalink /patch/212295/
State New
Headers show

Pull-request

git://github.com/afaerber/qemu-cpu.git memory-ioport

Comments

Andreas Färber - Jan. 15, 2013, 6:47 p.m.
Hello,

Here's a bugfix and a few more I/O port conversions to Memory API. Please pull.

Cc: Julien Grall <julien.grall@citrix.com>
Cc: Hervé Poussineau <hpoussin@reactos.org>


The following changes since commit cf7c3f0cb5a7129f57fa9e69d410d6a05031988c:

  virtio-9p: fix compilation error. (2013-01-14 18:52:39 -0600)

are available in the git repository at:

  git://github.com/afaerber/qemu-cpu.git memory-ioport

for you to fetch changes up to c3a29809e4d8924a0cfffd7f1af3c2f3c46f5889:

  acpi_piix4: Do not use old_portio-style callbacks (2013-01-15 19:45:45 +0100)

----------------------------------------------------------------
Hervé Poussineau (2):
      xen_platform: Do not use old_portio-style callbacks
      acpi_piix4: Do not use old_portio-style callbacks

Julien Grall (1):
      hw/dma.c: Fix conversion of ioport_register* to MemoryRegion

 hw/acpi_piix4.c   |   92 ++++++++++++++++++++++++-----------------------------
 hw/dma.c          |   22 ++++++-------
 hw/xen_platform.c |   21 ++++++------
 3 Dateien geändert, 62 Zeilen hinzugefügt(+), 73 Zeilen entfernt(-)
Anthony Liguori - Jan. 15, 2013, 11:02 p.m.
Hi,

Please adjust your pull request script to include a 0/M marker if you're
also including patches in the reply.

No worries about this request, but my new version tracker gets confused
because it marks this whole series as "broken" because it's impossible
for a non-human to tell if this is the cover letter or something silly
like a new top-level patch posted to this thread.

Regards,

Anthony Liguori

Andreas Färber <afaerber@suse.de> writes:

> Hello,
>
> Here's a bugfix and a few more I/O port conversions to Memory API. Please pull.
>
> Cc: Julien Grall <julien.grall@citrix.com>
> Cc: Hervé Poussineau <hpoussin@reactos.org>
>
>
> The following changes since commit cf7c3f0cb5a7129f57fa9e69d410d6a05031988c:
>
>   virtio-9p: fix compilation error. (2013-01-14 18:52:39 -0600)
>
> are available in the git repository at:
>
>   git://github.com/afaerber/qemu-cpu.git memory-ioport
>
> for you to fetch changes up to c3a29809e4d8924a0cfffd7f1af3c2f3c46f5889:
>
>   acpi_piix4: Do not use old_portio-style callbacks (2013-01-15 19:45:45 +0100)
>
> ----------------------------------------------------------------
> Hervé Poussineau (2):
>       xen_platform: Do not use old_portio-style callbacks
>       acpi_piix4: Do not use old_portio-style callbacks
>
> Julien Grall (1):
>       hw/dma.c: Fix conversion of ioport_register* to MemoryRegion
>
>  hw/acpi_piix4.c   |   92 ++++++++++++++++++++++++-----------------------------
>  hw/dma.c          |   22 ++++++-------
>  hw/xen_platform.c |   21 ++++++------
>  3 Dateien geändert, 62 Zeilen hinzugefügt(+), 73 Zeilen entfernt(-)
Andreas Färber - Jan. 16, 2013, midnight
Hi Anthony,

Am 16.01.2013 00:02, schrieb Anthony Liguori:
> 
> Please adjust your pull request script to include a 0/M marker if you're
> also including patches in the reply.

In the past it was you who specifically requested us to always include
the queue of patches part of that pull as reply! Is this no longer desired?

Or how would I generate 0/M from my bash script? git-request-pull
doesn't really fit into the "blurb" of a regular cover letter, coming
with its own stats, so that I generate the mail headers by script.

Regards,
Andreas

> No worries about this request, but my new version tracker gets confused
> because it marks this whole series as "broken" because it's impossible
> for a non-human to tell if this is the cover letter or something silly
> like a new top-level patch posted to this thread.
> 
> Regards,
> 
> Anthony Liguori
Anthony Liguori - Jan. 16, 2013, 12:35 a.m.
Andreas Färber <afaerber@suse.de> writes:

> Hi Anthony,
>
> Am 16.01.2013 00:02, schrieb Anthony Liguori:
>> 
>> Please adjust your pull request script to include a 0/M marker if you're
>> also including patches in the reply.
>
> In the past it was you who specifically requested us to always include
> the queue of patches part of that pull as reply! Is this no longer
> desired?

Yes, it is.  My patches tool handles PULL requests without them fine but
for QEMU, I want pull requests to include the patches being pulled.

If you're including patches (and you should), then the first mail should
indicate that it's the 0th mail of the series.

> Or how would I generate 0/M from my bash script? git-request-pull
> doesn't really fit into the "blurb" of a regular cover letter, coming
> with its own stats, so that I generate the mail headers by script.

I don't send pull requests so I'm the wrong person to ask.  Peter/Stefan, how
do ya'll do it?

Regards,

Anthony Liguori

>
> Regards,
> Andreas
>
>> No worries about this request, but my new version tracker gets confused
>> because it marks this whole series as "broken" because it's impossible
>> for a non-human to tell if this is the cover letter or something silly
>> like a new top-level patch posted to this thread.
>> 
>> Regards,
>> 
>> Anthony Liguori
>
> -- 
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
Anthony Liguori - Jan. 16, 2013, 1:18 a.m.
Pulled, thanks.

Regards,

Anthony Liguori
Peter Maydell - Jan. 16, 2013, 11:12 a.m.
On 16 January 2013 00:35, Anthony Liguori <anthony@codemonkey.ws> wrote:
> Andreas Färber <afaerber@suse.de> writes:
>> Or how would I generate 0/M from my bash script? git-request-pull
>> doesn't really fit into the "blurb" of a regular cover letter, coming
>> with its own stats, so that I generate the mail headers by script.
>
> I don't send pull requests so I'm the wrong person to ask.  Peter/Stefan, how
> do ya'll do it?

My script is http://people.linaro.org/~pmaydell/make-pullreq
Most of that is sanity checking, but the actual emails I generate by
doing a 'git format-patch --cover-letter', mangling the generated cover
letter a bit with sed to remove the duplicate set of stats, and then
appending the output of git-request-pull. I then edit the cover letter
by hand as needed for the specific pull.

-- PMM
Stefan Hajnoczi - Jan. 16, 2013, 12:56 p.m.
On Wed, Jan 16, 2013 at 11:12:45AM +0000, Peter Maydell wrote:
> On 16 January 2013 00:35, Anthony Liguori <anthony@codemonkey.ws> wrote:
> > Andreas Färber <afaerber@suse.de> writes:
> >> Or how would I generate 0/M from my bash script? git-request-pull
> >> doesn't really fit into the "blurb" of a regular cover letter, coming
> >> with its own stats, so that I generate the mail headers by script.
> >
> > I don't send pull requests so I'm the wrong person to ask.  Peter/Stefan, how
> > do ya'll do it?
> 
> My script is http://people.linaro.org/~pmaydell/make-pullreq
> Most of that is sanity checking, but the actual emails I generate by
> doing a 'git format-patch --cover-letter', mangling the generated cover
> letter a bit with sed to remove the duplicate set of stats, and then
> appending the output of git-request-pull. I then edit the cover letter
> by hand as needed for the specific pull.

I do the same but manually right now :).

Stefan