Patchwork [testsuite] fix ARM test gcc.target/arm/neon-vld1_dupQ.c

login
register
mail settings
Submitter Janis Johnson
Date Jan. 15, 2013, 4:31 p.m.
Message ID <50F5846E.6060102@mentor.com>
Download mbox | patch
Permalink /patch/212224/
State New
Headers show

Comments

Janis Johnson - Jan. 15, 2013, 4:31 p.m.
On 01/14/2013 03:04 PM, Janis Johnson wrote:
> Test gcc.target/arm/neon-vld1_dupQ.c started failing with r194594, a C
> front end change that causes the test to get warnings.  The test passes
> local variables of type int64x1_t to functions declared with arguments
> of type int64_t.  This patch casts the values passed to those arguments.
> It's possible that the patch invalidates the intent of the test, so I've
> copied the test's author.
> 
> OK for trunk?
> 
> Janis
> 

Here's the patch (thanks, Aldy!).
2013-01-14  Janis Johnson  <janisjo@codesourcery.com>

	* gcc.target/arm/neon-vld1_dupQ.c: Use types that match function
	prototypes.
Christophe LYON - Jan. 17, 2013, 12:44 p.m.
On 15.01.2013 17:31, Janis Johnson wrote:
> On 01/14/2013 03:04 PM, Janis Johnson wrote:
>> Test gcc.target/arm/neon-vld1_dupQ.c started failing with r194594, a C
>> front end change that causes the test to get warnings.  The test passes
>> local variables of type int64x1_t to functions declared with arguments
>> of type int64_t.  This patch casts the values passed to those arguments.
>> It's possible that the patch invalidates the intent of the test, so I've
>> copied the test's author.
>>
>> OK for trunk?
>>
>> Janis
>>
> Here's the patch (thanks, Aldy!).
It looks OK, altough you could also have changed the type of input and output to int64_t[2] to avoid casts.

Thanks,

Christophe.
Ramana Radhakrishnan - Jan. 22, 2013, 10:52 a.m.
On 01/15/13 16:31, Janis Johnson wrote:
> On 01/14/2013 03:04 PM, Janis Johnson wrote:
>> Test gcc.target/arm/neon-vld1_dupQ.c started failing with r194594, a C
>> front end change that causes the test to get warnings.  The test passes
>> local variables of type int64x1_t to functions declared with arguments
>> of type int64_t.  This patch casts the values passed to those arguments.
>> It's possible that the patch invalidates the intent of the test, so I've
>> copied the test's author.
>>
>> OK for trunk?
>>
>> Janis
>>
>
> Here's the patch (thanks, Aldy!).
>

This is OK.

Ramana

Patch

Index: gcc.target/arm/neon-vld1_dupQ.c
===================================================================
--- gcc.target/arm/neon-vld1_dupQ.c	(revision 195178)
+++ gcc.target/arm/neon-vld1_dupQ.c	(working copy)
@@ -13,9 +13,9 @@ 
   int64x1_t input[2] = {(int64x1_t)0x0123456776543210LL,
 			(int64x1_t)0x89abcdeffedcba90LL};
   int64x1_t output[2] = {0, 0};
-  int64x2_t var = vld1q_dup_s64(input);
+  int64x2_t var = vld1q_dup_s64((int64_t *)input);
 
-  vst1q_s64(output, var);
+  vst1q_s64((int64_t *)output, var);
   if (output[0] != (int64x1_t)0x0123456776543210LL)
     abort();
   if (output[1] != (int64x1_t)0x0123456776543210LL)