From patchwork Tue Jan 15 14:29:10 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Armbruster X-Patchwork-Id: 212178 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 4C23E2C009D for ; Wed, 16 Jan 2013 01:29:37 +1100 (EST) Received: from localhost ([::1]:55138 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tv7WB-00047c-9F for incoming@patchwork.ozlabs.org; Tue, 15 Jan 2013 09:29:35 -0500 Received: from eggs.gnu.org ([208.118.235.92]:51310) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tv7Vq-00044Z-5u for qemu-devel@nongnu.org; Tue, 15 Jan 2013 09:29:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tv7Vn-0006Uj-OI for qemu-devel@nongnu.org; Tue, 15 Jan 2013 09:29:14 -0500 Received: from oxygen.pond.sub.org ([2a01:4f8:121:10e4::3]:38113) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tv7Vn-0006UL-Ib for qemu-devel@nongnu.org; Tue, 15 Jan 2013 09:29:11 -0500 Received: from blackfin.pond.sub.org (p5B32AEB8.dip.t-dialin.net [91.50.174.184]) by oxygen.pond.sub.org (Postfix) with ESMTPA id D8B6F9FE64 for ; Tue, 15 Jan 2013 15:29:10 +0100 (CET) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 429F7200A9; Tue, 15 Jan 2013 15:29:10 +0100 (CET) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Tue, 15 Jan 2013 15:29:10 +0100 Message-Id: <1358260150-9760-5-git-send-email-armbru@redhat.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1358260150-9760-1-git-send-email-armbru@redhat.com> References: <1358260150-9760-1-git-send-email-armbru@redhat.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a01:4f8:121:10e4::3 Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@redhat.com Subject: [Qemu-devel] [PATCH v2 4/4] block: Fix how mirror_run() frees its buffer X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org It allocates with qemu_blockalign(), therefore it must free with qemu_vfree(), not g_free(). Signed-off-by: Markus Armbruster --- block/mirror.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/mirror.c b/block/mirror.c index 8aeacbf..6180aa3 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -225,7 +225,7 @@ static void coroutine_fn mirror_run(void *opaque) } immediate_exit: - g_free(s->buf); + qemu_vfree(s->buf); bdrv_set_dirty_tracking(bs, false); bdrv_iostatus_disable(s->target); if (s->should_complete && ret == 0) {