Remove clang-ism -Wno-c99-extensions from libsanitizer AM_CXXFLAGS

Submitted by Jakub Jelinek on Jan. 15, 2013, 9:10 a.m.

Details

Message ID 20130115091047.GU7269@tucnak.redhat.com
State New
Headers show

Commit Message

Jakub Jelinek Jan. 15, 2013, 9:10 a.m.
Hi!

The -Wno-c99-extensions option isn't supported by GCC (and never was), guess
Wei copied it over from llvm makefiles.  GCC normally doesn't error out on
it, just warns.

Fixed thusly, ok for trunk?

2013-01-15  Jakub Jelinek  <jakub@redhat.com>

	* sanitizer_common/Makefile.am (AM_CXXFLAGS): Remove
	-Wno-c99-extensions.
	* interception/Makefile.am (AM_CXXFLAGS): Likewise.
	* asan/Makefile.am (AM_CXXFLAGS): Likewise.
	* sanitizer_common/Makefile.in: Regenerated.
	* interception/Makefile.in: Regenerated.
	* asan/Makefile.in: Regenerated.


	Jakub

Comments

Richard Henderson Jan. 15, 2013, 11:11 p.m.
On 01/15/2013 01:10 AM, Jakub Jelinek wrote:
> 2013-01-15  Jakub Jelinek<jakub@redhat.com>
>
> 	* sanitizer_common/Makefile.am (AM_CXXFLAGS): Remove
> 	-Wno-c99-extensions.
> 	* interception/Makefile.am (AM_CXXFLAGS): Likewise.
> 	* asan/Makefile.am (AM_CXXFLAGS): Likewise.
> 	* sanitizer_common/Makefile.in: Regenerated.
> 	* interception/Makefile.in: Regenerated.
> 	* asan/Makefile.in: Regenerated.

Ok.


r~

Patch hide | download patch | download mbox

--- libsanitizer/sanitizer_common/Makefile.am.jj	2013-01-10 14:35:27.000000000 +0100
+++ libsanitizer/sanitizer_common/Makefile.am	2013-01-15 10:05:43.416659748 +0100
@@ -4,7 +4,7 @@  AM_CPPFLAGS = -I $(top_srcdir)/include
 gcc_version := $(shell cat $(top_srcdir)/../gcc/BASE-VER)
 
 DEFS = -D_GNU_SOURCE -D_DEBUG -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS 
-AM_CXXFLAGS = -Wall -W -Wno-unused-parameter -Wwrite-strings -pedantic -Wno-long-long  -fPIC -fno-builtin -fno-exceptions -fomit-frame-pointer -funwind-tables -fvisibility=hidden -Wno-variadic-macros -Wno-c99-extensions 
+AM_CXXFLAGS = -Wall -W -Wno-unused-parameter -Wwrite-strings -pedantic -Wno-long-long  -fPIC -fno-builtin -fno-exceptions -fomit-frame-pointer -funwind-tables -fvisibility=hidden -Wno-variadic-macros
 AM_CXXFLAGS += $(LIBSTDCXX_RAW_CXX_CXXFLAGS)
 ACLOCAL_AMFLAGS = -I m4
 
--- libsanitizer/sanitizer_common/Makefile.in.jj	2013-01-10 14:35:27.000000000 +0100
+++ libsanitizer/sanitizer_common/Makefile.in	2013-01-15 10:06:30.468383379 +0100
@@ -220,8 +220,7 @@  gcc_version := $(shell cat $(top_srcdir)
 AM_CXXFLAGS = -Wall -W -Wno-unused-parameter -Wwrite-strings -pedantic \
 	-Wno-long-long -fPIC -fno-builtin -fno-exceptions \
 	-fomit-frame-pointer -funwind-tables -fvisibility=hidden \
-	-Wno-variadic-macros -Wno-c99-extensions \
-	$(LIBSTDCXX_RAW_CXX_CXXFLAGS)
+	-Wno-variadic-macros $(LIBSTDCXX_RAW_CXX_CXXFLAGS)
 ACLOCAL_AMFLAGS = -I m4
 noinst_LTLIBRARIES = libsanitizer_common.la
 sanitizer_common_files = \
--- libsanitizer/interception/Makefile.am.jj	2012-12-12 23:32:04.000000000 +0100
+++ libsanitizer/interception/Makefile.am	2013-01-15 10:05:28.857743399 +0100
@@ -4,7 +4,7 @@  AM_CPPFLAGS = -I $(top_srcdir)/include
 gcc_version := $(shell cat $(top_srcdir)/../gcc/BASE-VER)
 
 DEFS = -D_GNU_SOURCE -D_DEBUG -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS 
-AM_CXXFLAGS = -Wall -W -Wno-unused-parameter -Wwrite-strings -pedantic -Wno-long-long  -fPIC -fno-builtin -fno-exceptions -fomit-frame-pointer -funwind-tables -fvisibility=hidden -Wno-variadic-macros -Wno-c99-extensions 
+AM_CXXFLAGS = -Wall -W -Wno-unused-parameter -Wwrite-strings -pedantic -Wno-long-long  -fPIC -fno-builtin -fno-exceptions -fomit-frame-pointer -funwind-tables -fvisibility=hidden -Wno-variadic-macros
 AM_CXXFLAGS += $(LIBSTDCXX_RAW_CXX_CXXFLAGS)
 ACLOCAL_AMFLAGS = -I m4
 
--- libsanitizer/interception/Makefile.in.jj	2012-12-12 23:32:04.000000000 +0100
+++ libsanitizer/interception/Makefile.in	2013-01-15 10:06:30.440383517 +0100
@@ -215,8 +215,7 @@  gcc_version := $(shell cat $(top_srcdir)
 AM_CXXFLAGS = -Wall -W -Wno-unused-parameter -Wwrite-strings -pedantic \
 	-Wno-long-long -fPIC -fno-builtin -fno-exceptions \
 	-fomit-frame-pointer -funwind-tables -fvisibility=hidden \
-	-Wno-variadic-macros -Wno-c99-extensions \
-	$(LIBSTDCXX_RAW_CXX_CXXFLAGS)
+	-Wno-variadic-macros $(LIBSTDCXX_RAW_CXX_CXXFLAGS)
 ACLOCAL_AMFLAGS = -I m4
 noinst_LTLIBRARIES = libinterception.la
 interception_files = \
--- libsanitizer/asan/Makefile.am.jj	2013-01-10 14:35:28.000000000 +0100
+++ libsanitizer/asan/Makefile.am	2013-01-15 10:04:45.030000400 +0100
@@ -7,7 +7,7 @@  DEFS = -D_GNU_SOURCE -D_DEBUG -D__STDC_C
 if USING_MAC_INTERPOSE
 DEFS += -DMAC_INTERPOSE_FUNCTIONS -DMISSING_BLOCKS_SUPPORT
 endif
-AM_CXXFLAGS = -Wall -W -Wno-unused-parameter -Wwrite-strings -pedantic -Wno-long-long  -fPIC -fno-builtin -fno-exceptions -fomit-frame-pointer -funwind-tables -fvisibility=hidden -Wno-variadic-macros -Wno-c99-extensions 
+AM_CXXFLAGS = -Wall -W -Wno-unused-parameter -Wwrite-strings -pedantic -Wno-long-long  -fPIC -fno-builtin -fno-exceptions -fomit-frame-pointer -funwind-tables -fvisibility=hidden -Wno-variadic-macros
 AM_CXXFLAGS += $(LIBSTDCXX_RAW_CXX_CXXFLAGS)
 ACLOCAL_AMFLAGS = -I $(top_srcdir) -I $(top_srcdir)/config
 
--- libsanitizer/asan/Makefile.in.jj	2013-01-10 14:35:28.000000000 +0100
+++ libsanitizer/asan/Makefile.in	2013-01-15 10:06:30.407383680 +0100
@@ -264,8 +264,7 @@  gcc_version := $(shell cat $(top_srcdir)
 AM_CXXFLAGS = -Wall -W -Wno-unused-parameter -Wwrite-strings -pedantic \
 	-Wno-long-long -fPIC -fno-builtin -fno-exceptions \
 	-fomit-frame-pointer -funwind-tables -fvisibility=hidden \
-	-Wno-variadic-macros -Wno-c99-extensions \
-	$(LIBSTDCXX_RAW_CXX_CXXFLAGS)
+	-Wno-variadic-macros $(LIBSTDCXX_RAW_CXX_CXXFLAGS)
 ACLOCAL_AMFLAGS = -I $(top_srcdir) -I $(top_srcdir)/config
 toolexeclib_LTLIBRARIES = libasan.la
 asan_files = \