Patchwork build: remove *.lo, *.a, *.la files from all subdirectories on make clean

login
register
mail settings
Submitter Paolo Bonzini
Date Jan. 15, 2013, 8:49 a.m.
Message ID <1358239777-29911-3-git-send-email-pbonzini@redhat.com>
Download mbox | patch
Permalink /patch/212035/
State New
Headers show

Comments

Paolo Bonzini - Jan. 15, 2013, 8:49 a.m.
.lo files in stubs/, util/ and libcacard/ were not cleaned.
Fix this.

Cc: Blue Swirl <blauwirbel@gmail.com>
Reported-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Stefan Hajnoczi - Jan. 15, 2013, 10:23 a.m.
On Tue, Jan 15, 2013 at 09:49:37AM +0100, Paolo Bonzini wrote:
> .lo files in stubs/, util/ and libcacard/ were not cleaned.
> Fix this.
> 
> Cc: Blue Swirl <blauwirbel@gmail.com>
> Reported-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  Makefile | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Paolo Bonzini - Jan. 25, 2013, 9:09 a.m.
Il 15/01/2013 09:49, Paolo Bonzini ha scritto:
> .lo files in stubs/, util/ and libcacard/ were not cleaned.
> Fix this.
> 
> Cc: Blue Swirl <blauwirbel@gmail.com>
> Reported-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  Makefile | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index cfa2fa6..6cee692 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -214,9 +214,9 @@ clean:
>  # avoid old build problems by removing potentially incorrect old files
>  	rm -f config.mak op-i386.h opc-i386.h gen-op-i386.h op-arm.h opc-arm.h gen-op-arm.h
>  	rm -f qemu-options.def
> -	find . -name '*.[od]' -type f -exec rm -f {} +
> -	rm -f *.a *.lo $(TOOLS) $(HELPERS-y) qemu-ga TAGS cscope.* *.pod *~ */*~
> -	rm -f *.la
> +	find . -name '*.[oda]' -type f -exec rm -f {} +
> +	find . -name '*.l[oa]' -type f -exec rm -f {} +
> +	rm -f $(TOOLS) $(HELPERS-y) qemu-ga TAGS cscope.* *.pod *~ */*~
>  	rm -Rf .libs
>  	rm -f qemu-img-cmds.h
>  	@# May not be present in GENERATED_HEADERS
> 

Ping.

Paolo
Michal Privoznik - Jan. 25, 2013, 9:38 a.m.
On 15.01.2013 09:49, Paolo Bonzini wrote:
> .lo files in stubs/, util/ and libcacard/ were not cleaned.
> Fix this.
> 
> Cc: Blue Swirl <blauwirbel@gmail.com>
> Reported-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  Makefile | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Blue Swirl - Jan. 26, 2013, 3:09 p.m.
Thanks, applied.

On Tue, Jan 15, 2013 at 8:49 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> .lo files in stubs/, util/ and libcacard/ were not cleaned.
> Fix this.
>
> Cc: Blue Swirl <blauwirbel@gmail.com>
> Reported-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  Makefile | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index cfa2fa6..6cee692 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -214,9 +214,9 @@ clean:
>  # avoid old build problems by removing potentially incorrect old files
>         rm -f config.mak op-i386.h opc-i386.h gen-op-i386.h op-arm.h opc-arm.h gen-op-arm.h
>         rm -f qemu-options.def
> -       find . -name '*.[od]' -type f -exec rm -f {} +
> -       rm -f *.a *.lo $(TOOLS) $(HELPERS-y) qemu-ga TAGS cscope.* *.pod *~ */*~
> -       rm -f *.la
> +       find . -name '*.[oda]' -type f -exec rm -f {} +
> +       find . -name '*.l[oa]' -type f -exec rm -f {} +
> +       rm -f $(TOOLS) $(HELPERS-y) qemu-ga TAGS cscope.* *.pod *~ */*~
>         rm -Rf .libs
>         rm -f qemu-img-cmds.h
>         @# May not be present in GENERATED_HEADERS
> --
> 1.8.1
>

Patch

diff --git a/Makefile b/Makefile
index cfa2fa6..6cee692 100644
--- a/Makefile
+++ b/Makefile
@@ -214,9 +214,9 @@  clean:
 # avoid old build problems by removing potentially incorrect old files
 	rm -f config.mak op-i386.h opc-i386.h gen-op-i386.h op-arm.h opc-arm.h gen-op-arm.h
 	rm -f qemu-options.def
-	find . -name '*.[od]' -type f -exec rm -f {} +
-	rm -f *.a *.lo $(TOOLS) $(HELPERS-y) qemu-ga TAGS cscope.* *.pod *~ */*~
-	rm -f *.la
+	find . -name '*.[oda]' -type f -exec rm -f {} +
+	find . -name '*.l[oa]' -type f -exec rm -f {} +
+	rm -f $(TOOLS) $(HELPERS-y) qemu-ga TAGS cscope.* *.pod *~ */*~
 	rm -Rf .libs
 	rm -f qemu-img-cmds.h
 	@# May not be present in GENERATED_HEADERS