Patchwork [v3] Makefile: rename cross target -> toolchain

login
register
mail settings
Submitter Fabio Porcedda
Date Jan. 15, 2013, 8:02 a.m.
Message ID <1358236920-14210-1-git-send-email-fabio.porcedda@gmail.com>
Download mbox | patch
Permalink /patch/212007/
State Accepted
Commit 2a78641583aa396dce64c00e1a3009796295d23c
Headers show

Comments

Fabio Porcedda - Jan. 15, 2013, 8:02 a.m.
- Use a more descriptive name, the same of the "toolchain" directory.
- Add missing dependencies to be able to successfully use the target
  right after the configuration.
- Move to a better position.
- Documentation it in the help target.
- Use toolchain target in the world target

Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
Reviewed-by: Markos Chandras <markos.chandras at imgtec.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
Acked-by: Samuel Martin <s.martin49 at gmail.com>
---

Changes:
v3:
 - squashed as suggested by Samuel
v2:
 - renamed cross to toolchain
 - use in world target

 Makefile | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
Peter Korsgaard - Jan. 15, 2013, 9:34 a.m.
>>>>> "Fabio" == Fabio Porcedda <fabio.porcedda@gmail.com> writes:

 Fabio> - Use a more descriptive name, the same of the "toolchain" directory.
 Fabio> - Add missing dependencies to be able to successfully use the target
 Fabio>   right after the configuration.
 Fabio> - Move to a better position.
 Fabio> - Documentation it in the help target.
 Fabio> - Use toolchain target in the world target

 Fabio> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
 Fabio> Reviewed-by: Markos Chandras <markos.chandras at imgtec.com>
 Fabio> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
 Fabio> Acked-by: Samuel Martin <s.martin49 at gmail.com>

Committed, thanks.

Patch

diff --git a/Makefile b/Makefile
index 1fc51e9..6f8ed0e 100644
--- a/Makefile
+++ b/Makefile
@@ -392,9 +392,11 @@  $(BUILD_DIR)/buildroot-config/auto.conf: $(BUILDROOT_CONFIG)
 
 prepare: $(BUILD_DIR)/buildroot-config/auto.conf
 
-world: prepare dirs dependencies $(BASE_TARGETS) $(TARGETS_ALL)
+toolchain: prepare dirs dependencies $(BASE_TARGETS)
 
-.PHONY: all world dirs clean distclean source outputmakefile \
+world: toolchain $(TARGETS_ALL)
+
+.PHONY: all world toolchain dirs clean distclean source outputmakefile \
 	legal-info legal-info-prepare legal-info-clean \
 	$(BASE_TARGETS) $(TARGETS) $(TARGETS_ALL) \
 	$(TARGETS_CLEAN) $(TARGETS_DIRCLEAN) $(TARGETS_SOURCE) $(TARGETS_LEGAL_INFO) \
@@ -715,8 +717,6 @@  ifeq ($(O),output)
 endif
 	rm -rf $(BUILDROOT_CONFIG) $(CONFIG_DIR)/.config.old $(CONFIG_DIR)/.auto.deps
 
-cross: $(BASE_TARGETS)
-
 help:
 	@echo 'Cleaning:'
 	@echo '  clean                  - delete all files created by build'
@@ -724,6 +724,7 @@  help:
 	@echo
 	@echo 'Build:'
 	@echo '  all                    - make world'
+	@echo '  toolchain              - build toolchain'
 	@echo '  <package>-rebuild      - force recompile <package>'
 	@echo '  <package>-reconfigure  - force reconfigure <package>'
 	@echo