From patchwork Mon Jan 14 20:22:56 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Klose X-Patchwork-Id: 211885 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id B31DD2C009A for ; Tue, 15 Jan 2013 07:23:20 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1358799801; h=Comment: DomainKey-Signature:Received:Received:Received:Received: Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:Sender:Delivered-To; bh=Bg8Y2Yw I5reYXnxkgy5Q5dHGM6w=; b=Ap45CZPxVEgLlfEKs+qAFlfA1Uz0ARc0611L3R6 BSJJaiQZUyOJObV4y2yJoei1sDijuLsah/0HE9Ir7YSr2+RiIXbIHL/TchM3NNkV XZ0sBrFoMhM8gB+OeC23/rte+VO0mcDo+hZXdUdb3wtIJluVdRclSoNQV5BzjSu0 8L9M= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=N1tH/uvJs9EJN2gSDGOSCjsxTSvkLdLR3zEzXwPIWtx22cn2nhcdPJbNy0vpET 7fvFRfzrQXOAzi/VVhpATKTx1TH2pIUPA6xcP93ZiFJzNfkasyIi43RspYKgoL5t ExRTcyRNAD2iX+YJx6aieHiMvc6l50swXUN91c+x5MJpA=; Received: (qmail 31245 invoked by alias); 14 Jan 2013 20:23:13 -0000 Received: (qmail 31237 invoked by uid 22791); 14 Jan 2013 20:23:10 -0000 X-SWARE-Spam-Status: No, hits=-0.2 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, RCVD_IN_DNSWL_LOW, URIBL_BLACK X-Spam-Check-By: sourceware.org Received: from youngberry.canonical.com (HELO youngberry.canonical.com) (91.189.89.112) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Jan 2013 20:23:06 +0000 Received: from dslb-088-073-072-133.pools.arcor-ip.net ([88.73.72.133] helo=[192.168.42.216]) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1TuqYi-0002ho-VV; Mon, 14 Jan 2013 20:23:05 +0000 Message-ID: <50F46920.1030000@ubuntu.com> Date: Mon, 14 Jan 2013 21:22:56 +0100 From: Matthias Klose User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: GCC Patches CC: wookey@debian.org Subject: [patch] --with-build-sysroot requires --with-sysroot Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org this is documented in doc/install.texi: """ This option is only useful when you are already using @option{--with-sysroot}.""" now, lets error out if you configure --with-build-sysroot without --with-sysroot. Ok for the trunk? This was hit in PR55743. I think the patch in http://gcc.gnu.org/ml/gcc-patches/2013-01/msg00198.html is still valid, but independent of this. Matthias gcc/ 2013-01-14 Matthias Klose * configure.ac: fail --with-build-sysroot without --with-sysroot. * configure: Regenerate. Index: gcc/configure.ac =================================================================== --- gcc/configure.ac (Revision 195151) +++ gcc/configure.ac (Arbeitskopie) @@ -755,15 +755,6 @@ configured_native_system_header_dir="${withval}" ], [configured_native_system_header_dir=]) -AC_ARG_WITH(build-sysroot, - [AS_HELP_STRING([--with-build-sysroot=sysroot], - [use sysroot as the system root during the build])], - [if test x"$withval" != x ; then - SYSROOT_CFLAGS_FOR_TARGET="--sysroot=$withval" - fi], - [SYSROOT_CFLAGS_FOR_TARGET=]) -AC_SUBST(SYSROOT_CFLAGS_FOR_TARGET) - if test "x$prefix" = xNONE; then test_prefix=/usr/local else @@ -805,6 +796,19 @@ AC_SUBST(TARGET_SYSTEM_ROOT_DEFINE) AC_SUBST(CROSS_SYSTEM_HEADER_DIR) +AC_ARG_WITH(build-sysroot, + [AS_HELP_STRING([--with-build-sysroot=sysroot], + [use sysroot as the system root during the build])], + [if test x"$withval" != x ; then + SYSROOT_CFLAGS_FOR_TARGET="--sysroot=$withval" + fi], + [SYSROOT_CFLAGS_FOR_TARGET=]) +AC_SUBST(SYSROOT_CFLAGS_FOR_TARGET) +if test x"$TARGET_SYSTEM_ROOT" = x && test x"$SYSROOT_CFLAGS_FOR_TARGET" != x +then + AC_MSG_ERROR([option --with-build-sysroot requires --with-sysroot]) +fi + AC_ARG_WITH(specs, [AS_HELP_STRING([--with-specs=SPECS], [add SPECS to driver command-line processing])],