From patchwork Mon Jan 14 20:20:39 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jack Howarth X-Patchwork-Id: 211884 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 6E02A2C009C for ; Tue, 15 Jan 2013 07:21:18 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1358799679; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To:User-Agent: Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:Sender:Delivered-To; bh=sK++9lPJS9mbMGWECp/j PujkJdg=; b=CmT7nfinM1ZPtREhkmUDy0EFRdR3QcOtuApYxpsYjQq+7ZLNsI/J 4oRTyF87i6STMd3cwj0zUpVd+ipTR8y4mTtax7gBfhJh+0ERn855OJ6Cf1HaZbcE cYDTwW+BnOAEMWCcaOGq4iU58u25s4gPuUqlEOCbg+CGNmIFZnvZ9M0= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To:User-Agent:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=GSyKOJwxEr0vI/JIHZYi/qb/aaVwj/WHcTuDhKfAMdo6rOOd/UYiCQBrMRY43O fKh1BqLdLuPaf2RtoiGlUAxK7DmRMMpPjKT4VoUCUqJABswkPsiT+ipsL+4BKbkT XqqPGPihXtUTSnhkKeMjFCcgPCl22+eJ8QKbSIo62LhNY=; Received: (qmail 29433 invoked by alias); 14 Jan 2013 20:20:53 -0000 Received: (qmail 29412 invoked by uid 22791); 14 Jan 2013 20:20:47 -0000 X-SWARE-Spam-Status: No, hits=0.2 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, URIBL_BLACK X-Spam-Check-By: sourceware.org Received: from bromo.med.uc.edu (HELO bromo.med.uc.edu) (129.137.3.146) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Jan 2013 20:20:42 +0000 Received: from bromo.med.uc.edu (localhost.localdomain [127.0.0.1]) by bromo.med.uc.edu (Postfix) with ESMTP id BBD7E400007; Mon, 14 Jan 2013 15:20:39 -0500 (EST) Received: (from howarth@localhost) by bromo.med.uc.edu (8.14.3/8.14.3/Submit) id r0EKKdQU022285; Mon, 14 Jan 2013 15:20:39 -0500 Date: Mon, 14 Jan 2013 15:20:39 -0500 From: Jack Howarth To: Dominique Dhumieres Cc: gcc-patches@gcc.gnu.org, tobias@grosser.es, rguenther@suse.de Subject: Re: [PATCH] Allow new ISL/CLooG versions Message-ID: <20130114202039.GA22255@bromo.med.uc.edu> References: <20130114192712.BE33A3BE1B@mailhost.lps.ens.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130114192712.BE33A3BE1B@mailhost.lps.ens.fr> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Mon, Jan 14, 2013 at 08:27:12PM +0100, Dominique Dhumieres wrote: > In order to bootstrap r195167 with the new ISL/CLooG versions, > I had to apply the following patch: > > --- ../work/configure 2013-01-14 19:32:00.000000000 +0100 > +++ configure 2013-01-14 19:42:15.000000000 +0100 > @@ -5848,7 +5848,7 @@ else > int > main () > { > -if (strncmp (isl_version (), "isl-0.10", strlen ("isl-0.10")) != 0) > +if (strncmp (isl_version (), "isl-0.11", strlen ("isl-0.11")) != 0) > return 1; > > ; > @@ -6033,7 +6033,7 @@ int > main () > { > #if CLOOG_VERSION_MAJOR != 0 \ > - || CLOOG_VERSION_MINOR != 17 \ > + || CLOOG_VERSION_MINOR != 18 \ > || CLOOG_VERSION_REVISION < 0 > choke me > #endif > > (I didn't bother to update the messages: got > checking for version 0.10 of ISL... yes > checking for version 0.17.0 of CLooG... yes). > > Dominique Dominique, I believe that hack effectively changes... Richard seems to be assuming that the second call to ISL_CHECK_VERSION(0,11) in configure.ac will rerun the isl checks on 0.11.x but I suspect this doesn't take in account the caching of the results from the first call to ISL_CHECK_VERSION(). Certainly from my config.log against isl 0.11.1 and cloog 0.18.0, it appears that the version tests from the ISL_CHECK_VERSION(0,11) call aren't run and the cached result from the first ISL_CHECK_VERSION(0,10) is used instead. Jack Index: configure.ac =================================================================== --- configure.ac (revision 195174) +++ configure.ac (working copy) @@ -1607,7 +1607,7 @@ if test "x$with_isl" != "xno" && dnl with user input. ISL_INIT_FLAGS dnl The versions of ISL that work for Graphite - ISL_CHECK_VERSION(0,10) + ISL_CHECK_VERSION(0,11) if test "${gcc_cv_isl}" = no ; then ISL_CHECK_VERSION(0,11) fi