Patchwork linux-next: Tree for Jan 14 (mtd)

login
register
mail settings
Submitter Robert Jarzmik
Date Jan. 14, 2013, 7:01 p.m.
Message ID <874nija8ry.fsf@free.fr>
Download mbox | patch
Permalink /patch/211862/
State Accepted
Commit bf65aaa637cabae0386fe46b1ad5cd16997474f5
Headers show

Comments

Robert Jarzmik - Jan. 14, 2013, 7:01 p.m.
Randy Dunlap <rdunlap@infradead.org> writes:
> ERROR: "byte_rev_table" [drivers/mtd/devices/docg3.ko] undefined!

Thanks for the report. I have a trivial patch attached. Should it go through
Artem's tree or do you want to take it directly ?

Cheers.

--
Robert

---8>---

From 771d13b0094421b98310171d8794f2a793ec5d4d Mon Sep 17 00:00:00 2001
From: Robert Jarzmik <robert.jarzmik@free.fr>
Date: Mon, 9 Apr 2012 13:19:08 +0200
Subject: [PATCH] mtd: docg3 fix missing bitreverse lib

Fix missing dependency which can cause a build error such
as: ERROR: "byte_rev_table" [drivers/mtd/devices/docg3.ko]
undefined!

Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
---
 drivers/mtd/devices/Kconfig |    1 +
 1 file changed, 1 insertion(+)
Randy Dunlap - Jan. 14, 2013, 7:13 p.m.
On 01/14/13 11:01, Robert Jarzmik wrote:
> Randy Dunlap <rdunlap@infradead.org> writes:
>> ERROR: "byte_rev_table" [drivers/mtd/devices/docg3.ko] undefined!
> 
> Thanks for the report. I have a trivial patch attached. Should it go through
> Artem's tree or do you want to take it directly ?

Acked-by: Randy Dunlap <rdunlap@infradead.org>

I suppose that it should go thru Artem's tree.

Thanks.


> Cheers.
> 
> --
> Robert
> 
> ---8>---
> 
> From 771d13b0094421b98310171d8794f2a793ec5d4d Mon Sep 17 00:00:00 2001
> From: Robert Jarzmik <robert.jarzmik@free.fr>
> Date: Mon, 9 Apr 2012 13:19:08 +0200
> Subject: [PATCH] mtd: docg3 fix missing bitreverse lib
> 
> Fix missing dependency which can cause a build error such
> as: ERROR: "byte_rev_table" [drivers/mtd/devices/docg3.ko]
> undefined!
> 
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
> ---
>  drivers/mtd/devices/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mtd/devices/Kconfig b/drivers/mtd/devices/Kconfig
> index 27f80cd..46dcb54 100644
> --- a/drivers/mtd/devices/Kconfig
> +++ b/drivers/mtd/devices/Kconfig
> @@ -272,6 +272,7 @@ config MTD_DOCG3
>  	tristate "M-Systems Disk-On-Chip G3"
>  	select BCH
>  	select BCH_CONST_PARAMS
> +	select BITREVERSE
>  	---help---
>  	  This provides an MTD device driver for the M-Systems DiskOnChip
>  	  G3 devices.
>
Artem Bityutskiy - Jan. 15, 2013, 10:21 a.m.
On Mon, 2013-01-14 at 20:01 +0100, Robert Jarzmik wrote:
> Randy Dunlap <rdunlap@infradead.org> writes:
> > ERROR: "byte_rev_table" [drivers/mtd/devices/docg3.ko] undefined!
> 
> Thanks for the report. I have a trivial patch attached. Should it go through
> Artem's tree or do you want to take it directly ?

David just picked this patch to the MTD tree.

Patch

diff --git a/drivers/mtd/devices/Kconfig b/drivers/mtd/devices/Kconfig
index 27f80cd..46dcb54 100644
--- a/drivers/mtd/devices/Kconfig
+++ b/drivers/mtd/devices/Kconfig
@@ -272,6 +272,7 @@  config MTD_DOCG3
 	tristate "M-Systems Disk-On-Chip G3"
 	select BCH
 	select BCH_CONST_PARAMS
+	select BITREVERSE
 	---help---
 	  This provides an MTD device driver for the M-Systems DiskOnChip
 	  G3 devices.