Patchwork [U-Boot,v2] mx6qsabre_common: Let mmc partition be board specific

login
register
mail settings
Submitter Fabio Estevam
Date Jan. 14, 2013, 6:59 p.m.
Message ID <1358189964-12586-1-git-send-email-festevam@gmail.com>
Download mbox | patch
Permalink /patch/211861/
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show

Comments

Fabio Estevam - Jan. 14, 2013, 6:59 p.m.
From: Fabio Estevam <fabio.estevam@freescale.com>

commit 49ea0ff5 (49ea0ff5) introduced CONFIG_SYS_MMC_ENV_PART into mx6qsabresd.h
to store the mmc partition, but in order for it to have effect we should place
it into 'mmcpart' variable.

Also add CONFIG_SYS_MMC_ENV_PART into mx6qsabreauto.h.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Changes since v1:
- Drop duplicated mmcpart
 include/configs/mx6qsabre_common.h |    2 +-
 include/configs/mx6qsabreauto.h    |    1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
Fabio Estevam - Jan. 22, 2013, 2:42 p.m.
Hi Stefano,

On Mon, Jan 14, 2013 at 4:59 PM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> commit 49ea0ff5 (49ea0ff5) introduced CONFIG_SYS_MMC_ENV_PART into mx6qsabresd.h
> to store the mmc partition, but in order for it to have effect we should place
> it into 'mmcpart' variable.
>
> Also add CONFIG_SYS_MMC_ENV_PART into mx6qsabreauto.h.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Changes since v1:
> - Drop duplicated mmcpart
>  include/configs/mx6qsabre_common.h |    2 +-
>  include/configs/mx6qsabreauto.h    |    1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)

Does this one look good now?

Thanks,

Fabio Estevam
Stefano Babic - Jan. 22, 2013, 3:06 p.m.
On 22/01/2013 15:42, Fabio Estevam wrote:
> Hi Stefano,
> 

Hi Fabio,

> On Mon, Jan 14, 2013 at 4:59 PM, Fabio Estevam <festevam@gmail.com> wrote:
>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> commit 49ea0ff5 (49ea0ff5) introduced CONFIG_SYS_MMC_ENV_PART into mx6qsabresd.h
>> to store the mmc partition, but in order for it to have effect we should place
>> it into 'mmcpart' variable.
>>
>> Also add CONFIG_SYS_MMC_ENV_PART into mx6qsabreauto.h.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>> ---
>> Changes since v1:
>> - Drop duplicated mmcpart
>>  include/configs/mx6qsabre_common.h |    2 +-
>>  include/configs/mx6qsabreauto.h    |    1 +
>>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> Does this one look good now?

Yes, it is, it is in my queue for next merge.

Regards,
Stefano
Stefano Babic - Jan. 28, 2013, 5:45 a.m.
On 14/01/2013 19:59, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> commit 49ea0ff5 (49ea0ff5) introduced CONFIG_SYS_MMC_ENV_PART into mx6qsabresd.h
> to store the mmc partition, but in order for it to have effect we should place
> it into 'mmcpart' variable.
> 
> Also add CONFIG_SYS_MMC_ENV_PART into mx6qsabreauto.h.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Patch

diff --git a/include/configs/mx6qsabre_common.h b/include/configs/mx6qsabre_common.h
index cda4512..d76357c 100644
--- a/include/configs/mx6qsabre_common.h
+++ b/include/configs/mx6qsabre_common.h
@@ -91,7 +91,7 @@ 
 	"fdt_high=0xffffffff\0"	  \
 	"initrd_high=0xffffffff\0" \
 	"mmcdev=" __stringify(CONFIG_SYS_MMC_ENV_DEV) "\0" \
-	"mmcpart=1\0" \
+	"mmcpart=" __stringify(CONFIG_SYS_MMC_ENV_PART) "\0" \
 	"mmcroot=" CONFIG_MMCROOT " rootwait rw\0" \
 	"mmcargs=setenv bootargs console=${console},${baudrate} " \
 		"root=${mmcroot}\0" \
diff --git a/include/configs/mx6qsabreauto.h b/include/configs/mx6qsabreauto.h
index f4a082a..bdf36b3 100644
--- a/include/configs/mx6qsabreauto.h
+++ b/include/configs/mx6qsabreauto.h
@@ -24,6 +24,7 @@ 
 #define CONFIG_SYS_FSL_USDHC_NUM	2
 #if defined(CONFIG_ENV_IS_IN_MMC)
 #define CONFIG_SYS_MMC_ENV_DEV		0
+#define CONFIG_SYS_MMC_ENV_PART		1	/* Boot partition 1 */
 #endif
 
 #endif                         /* __MX6QSABREAUTO_CONFIG_H */