| Submitter | Cong Ding |
|---|---|
| Date | Jan. 14, 2013, 6:57 p.m. |
| Message ID | <1358189864-28735-1-git-send-email-dinggnu@gmail.com> |
| Download | mbox | patch |
| Permalink | /patch/211860/ |
| State | Rejected |
| Delegated to: | David Miller |
| Headers | show |
Comments
From: Cong Ding <dinggnu@gmail.com> Date: Mon, 14 Jan 2013 18:57:43 +0000 > the variable err is uninitialized if all the macros in the function are > disabled. Which is never possible because of the Kconfig dependencies. This is what happens when you focus to narrowly on a piece of code, you take no context whatsoever into consideration. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Patch
diff --git a/drivers/atm/fore200e.c b/drivers/atm/fore200e.c index 204814e..d4725fc 100644 --- a/drivers/atm/fore200e.c +++ b/drivers/atm/fore200e.c @@ -2780,7 +2780,7 @@ static struct pci_driver fore200e_pca_driver = { static int __init fore200e_module_init(void) { - int err; + int err = 0; printk(FORE200E "FORE Systems 200E-series ATM driver - version " FORE200E_VERSION "\n");
the variable err is uninitialized if all the macros in the function are disabled. Signed-off-by: Cong Ding <dinggnu@gmail.com> --- drivers/atm/fore200e.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)