Patchwork [6/6] usb-host: Initialize dev->port the obviously safe way

login
register
mail settings
Submitter Gerd Hoffmann
Date Jan. 14, 2013, 11:50 a.m.
Message ID <1358164219-14070-7-git-send-email-kraxel@redhat.com>
Download mbox | patch
Permalink /patch/211771/
State New
Headers show

Comments

Gerd Hoffmann - Jan. 14, 2013, 11:50 a.m.
From: Markus Armbruster <armbru@redhat.com>

Coverity worries the strcpy() could overrun the destination.  It
can't, because the source always points to usb_host_scan()'s auto
port[], which has the same size.  Use pstrcpy() anyway, to hush the
checker.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/usb/host-linux.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/hw/usb/host-linux.c b/hw/usb/host-linux.c
index a498840..ad75ce0 100644
--- a/hw/usb/host-linux.c
+++ b/hw/usb/host-linux.c
@@ -1314,7 +1314,7 @@  static int usb_host_open(USBHostDevice *dev, int bus_num,
 
     dev->bus_num = bus_num;
     dev->addr = addr;
-    strcpy(dev->port, port);
+    pstrcpy(dev->port, sizeof(dev->port), port);
     dev->fd = fd;
 
     /* read the device description */