| Message ID | 1358147387-8221-10-git-send-email-xiawenc@linux.vnet.ibm.com |
|---|---|
| State | New |
| Headers | show |
On Mon, 14 Jan 2013 15:09:45 +0800 Wenchao Xia <xiawenc@linux.vnet.ibm.com> wrote: > Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com> This function is really a hmp.c-only helper. It does two more or less unrelated things, I think it's better not to spread it over other qemu source files. > --- > hmp.c | 2 +- > hmp.h | 2 ++ > 2 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/hmp.c b/hmp.c > index 2465d9b..89a1a8c 100644 > --- a/hmp.c > +++ b/hmp.c > @@ -23,7 +23,7 @@ > #include "monitor/monitor.h" > #include "ui/console.h" > > -static void hmp_handle_error(Monitor *mon, Error **errp) > +void hmp_handle_error(Monitor *mon, Error **errp) > { > if (error_is_set(errp)) { > monitor_printf(mon, "%s\n", error_get_pretty(*errp)); > diff --git a/hmp.h b/hmp.h > index 5cab9c0..da1a35c 100644 > --- a/hmp.h > +++ b/hmp.h > @@ -17,7 +17,9 @@ > #include "qemu-common.h" > #include "qapi-types.h" > #include "qapi/qmp/qdict.h" > +#include "qapi/error.h" > > +void hmp_handle_error(Monitor *mon, Error **errp); > void hmp_info_name(Monitor *mon, const QDict *qdict); > void hmp_info_version(Monitor *mon, const QDict *qdict); > void hmp_info_kvm(Monitor *mon, const QDict *qdict);
diff --git a/hmp.c b/hmp.c index 2465d9b..89a1a8c 100644 --- a/hmp.c +++ b/hmp.c @@ -23,7 +23,7 @@ #include "monitor/monitor.h" #include "ui/console.h" -static void hmp_handle_error(Monitor *mon, Error **errp) +void hmp_handle_error(Monitor *mon, Error **errp) { if (error_is_set(errp)) { monitor_printf(mon, "%s\n", error_get_pretty(*errp)); diff --git a/hmp.h b/hmp.h index 5cab9c0..da1a35c 100644 --- a/hmp.h +++ b/hmp.h @@ -17,7 +17,9 @@ #include "qemu-common.h" #include "qapi-types.h" #include "qapi/qmp/qdict.h" +#include "qapi/error.h" +void hmp_handle_error(Monitor *mon, Error **errp); void hmp_info_name(Monitor *mon, const QDict *qdict); void hmp_info_version(Monitor *mon, const QDict *qdict); void hmp_info_kvm(Monitor *mon, const QDict *qdict);
Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com> --- hmp.c | 2 +- hmp.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletions(-)