From patchwork Sun Jan 13 20:30:31 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: testsuite: missing or wrong dg-* directives? From: Harald Anlauf X-Patchwork-Id: 211650 Message-Id: <50F31967.4050003@gmx.de> To: Mikael Morin Cc: fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org Date: Sun, 13 Jan 2013 21:30:31 +0100 On 01/12/13 22:02, Mikael Morin wrote: > Le 08/01/2013 22:32, Harald Anlauf a écrit : >> On 12/28/12 21:49, Harald Anlauf wrote: >>> Hello all, >>> >>> is there a default directive that is assumed when the testsuite is run? >>> >>> Running an "fgrep -L" on the fortran testsuite, I found several files >>> that are missing either dg-do compile or run. >>> >>> I also found a funny typo in gomp/appendix-a/a.11.2.f90 >>> ! { do-do compile } >> >> find gfortran.dg -name "*.[fF]90" -o -name "*.[fF]" | \ >> xargs fgrep -w -L 'dg-do' | \ >> xargs head -1 -v >> >> and manual inspection of the resulting output results in: >> >> - Typos >> > [...] >> >> - Possibly missing { dg-do run } >> > [...] > > Mind sending patch and changelog to @gcc-patches ? > Here we go. No failures, but additional passes because of the dg-do run's. Somebody please take care of it? Harald 2013-01-13 Harald Anlauf * gfortran.dg/aint_anint_1.f90: Add dg-do run. * gfortran.dg/bounds_check_4.f90: Likewise. * gfortran.dg/inquire_10.f90: Likewise. * gfortran.dg/minloc_3.f90: Likewise. * gfortran.dg/minlocval_3.f90: Likewise. * gfortran.dg/module_double_reuse.f90: Likewise. * gfortran.dg/mvbits_1.f90: Likewise. * gfortran.dg/oldstyle_1.f90: Likewise. * gfortran.dg/pr20163-2.f: Likewise. * gfortran.dg/save_1.f90: Likewise. * gfortran.dg/scan_1.f90: Likewise. * gfortran.dg/select_char_1.f90: Likewise. * gfortran.dg/shape_4.f90: Likewise. * gfortran.dg/coarray_29_2.f90: Fix dg-do directive. * gfortran.dg/function_optimize_10.f90: Likewise. * gfortran.dg/gomp/appendix-a/a.11.2.f90: Likewise. * gfortran.dg/used_types_17.f90: Likewise. * gfortran.dg/used_types_18.f90: Likewise. Index: gcc/testsuite/gfortran.dg/oldstyle_1.f90 =================================================================== --- gcc/testsuite/gfortran.dg/oldstyle_1.f90 (revision 195136) +++ gcc/testsuite/gfortran.dg/oldstyle_1.f90 (working copy) @@ -1,3 +1,4 @@ +! { dg-do run } integer i, j /1/, g/2/, h ! { dg-warning "" "" } integer k, l(3) /2*2,1/ ! { dg-warning "" "" } real pi /3.1416/, e ! { dg-warning "" "" } Index: gcc/testsuite/gfortran.dg/scan_1.f90 =================================================================== --- gcc/testsuite/gfortran.dg/scan_1.f90 (revision 195136) +++ gcc/testsuite/gfortran.dg/scan_1.f90 (working copy) @@ -1,3 +1,4 @@ +! { dg-do run } program b integer w character(len=2) s, t Index: gcc/testsuite/gfortran.dg/aint_anint_1.f90 =================================================================== --- gcc/testsuite/gfortran.dg/aint_anint_1.f90 (revision 195136) +++ gcc/testsuite/gfortran.dg/aint_anint_1.f90 (working copy) @@ -1,3 +1,4 @@ +! { dg-do run } program aint_anint_1 implicit none Index: gcc/testsuite/gfortran.dg/gomp/appendix-a/a.11.2.f90 =================================================================== --- gcc/testsuite/gfortran.dg/gomp/appendix-a/a.11.2.f90 (revision 195136) +++ gcc/testsuite/gfortran.dg/gomp/appendix-a/a.11.2.f90 (working copy) @@ -1,4 +1,4 @@ -! { do-do compile } +! { dg-do compile } SUBROUTINE A11_2(AA, BB, CC, DD, EE, FF, N) INTEGER N Index: gcc/testsuite/gfortran.dg/bounds_check_4.f90 =================================================================== --- gcc/testsuite/gfortran.dg/bounds_check_4.f90 (revision 195136) +++ gcc/testsuite/gfortran.dg/bounds_check_4.f90 (working copy) @@ -1,3 +1,4 @@ +! { dg-do run } subroutine foo(n,x) implicit none integer, intent(in) :: n Index: gcc/testsuite/gfortran.dg/save_1.f90 =================================================================== --- gcc/testsuite/gfortran.dg/save_1.f90 (revision 195136) +++ gcc/testsuite/gfortran.dg/save_1.f90 (working copy) @@ -1,3 +1,4 @@ +! { dg-do run } ! { dg-options "-O2 -fno-automatic" } subroutine foo (b) logical b Index: gcc/testsuite/gfortran.dg/coarray_29_2.f90 =================================================================== --- gcc/testsuite/gfortran.dg/coarray_29_2.f90 (revision 195136) +++ gcc/testsuite/gfortran.dg/coarray_29_2.f90 (working copy) @@ -1,4 +1,4 @@ -! { dg-compile } +! { dg-do compile } ! { dg-options "-fcoarray=single" } ! Requires that coarray_29.f90 has been compiled before Index: gcc/testsuite/gfortran.dg/pr20163-2.f =================================================================== --- gcc/testsuite/gfortran.dg/pr20163-2.f (revision 195136) +++ gcc/testsuite/gfortran.dg/pr20163-2.f (working copy) @@ -1,3 +1,4 @@ +! { dg-do run } open(10,status="foo",err=100) ! { dg-warning "STATUS specifier in OPEN statement .* has invalid value" } call abort 100 continue Index: gcc/testsuite/gfortran.dg/minloc_3.f90 =================================================================== --- gcc/testsuite/gfortran.dg/minloc_3.f90 (revision 195136) +++ gcc/testsuite/gfortran.dg/minloc_3.f90 (working copy) @@ -1,3 +1,4 @@ +! { dg-do run } real :: a(30), m real, allocatable :: c(:) integer :: e(30), n, ia(1) Index: gcc/testsuite/gfortran.dg/used_types_18.f90 =================================================================== --- gcc/testsuite/gfortran.dg/used_types_18.f90 (revision 195136) +++ gcc/testsuite/gfortran.dg/used_types_18.f90 (working copy) @@ -1,4 +1,4 @@ -! { dg do-compile } +! { dg-do compile } ! { dg-options "-std=f2003" } ! ! Fortran 2003 allowes TYPE without components Index: gcc/testsuite/gfortran.dg/select_char_1.f90 =================================================================== --- gcc/testsuite/gfortran.dg/select_char_1.f90 (revision 195136) +++ gcc/testsuite/gfortran.dg/select_char_1.f90 (working copy) @@ -1,3 +1,4 @@ +! { dg-do run } integer function char_select (s) character(len=*), intent(in) :: s Index: gcc/testsuite/gfortran.dg/minlocval_3.f90 =================================================================== --- gcc/testsuite/gfortran.dg/minlocval_3.f90 (revision 195136) +++ gcc/testsuite/gfortran.dg/minlocval_3.f90 (working copy) @@ -1,3 +1,4 @@ +! { dg-do run } real :: a(30), b(10, 10), m real, allocatable :: c(:), d(:, :) integer :: e(30), f(10, 10), n Index: gcc/testsuite/gfortran.dg/function_optimize_10.f90 =================================================================== --- gcc/testsuite/gfortran.dg/function_optimize_10.f90 (revision 195136) +++ gcc/testsuite/gfortran.dg/function_optimize_10.f90 (working copy) @@ -1,4 +1,4 @@ -! { do-do run } +! { dg-do run } ! PR 51858 - this used to generate wrong code. ! Original test case by Don Simons. Index: gcc/testsuite/gfortran.dg/inquire_10.f90 =================================================================== --- gcc/testsuite/gfortran.dg/inquire_10.f90 (revision 195136) +++ gcc/testsuite/gfortran.dg/inquire_10.f90 (working copy) @@ -1,3 +1,4 @@ +! { dg-do run } character(len=800) :: cwd integer :: unit Index: gcc/testsuite/gfortran.dg/module_double_reuse.f90 =================================================================== --- gcc/testsuite/gfortran.dg/module_double_reuse.f90 (revision 195136) +++ gcc/testsuite/gfortran.dg/module_double_reuse.f90 (working copy) @@ -1,3 +1,4 @@ +! { dg-do run } ! Test of fix for PR18878 ! ! Based on example in PR by Steve Kargl Index: gcc/testsuite/gfortran.dg/mvbits_1.f90 =================================================================== --- gcc/testsuite/gfortran.dg/mvbits_1.f90 (revision 195136) +++ gcc/testsuite/gfortran.dg/mvbits_1.f90 (working copy) @@ -1,3 +1,4 @@ +! { dg-do run } ! PR 25577 ! MVBITS didn't work correctly for integer types wider than a C int ! The testcase is based on the one Dale Ranta posted in the bug report Index: gcc/testsuite/gfortran.dg/shape_4.f90 =================================================================== --- gcc/testsuite/gfortran.dg/shape_4.f90 (revision 195136) +++ gcc/testsuite/gfortran.dg/shape_4.f90 (working copy) @@ -1,3 +1,4 @@ +! { dg-do run } ! PR 35001 - we need to return 0 for the shapes of ! negative extents. Test case adapted from Tobias Burnus. program main Index: gcc/testsuite/gfortran.dg/used_types_17.f90 =================================================================== --- gcc/testsuite/gfortran.dg/used_types_17.f90 (revision 195136) +++ gcc/testsuite/gfortran.dg/used_types_17.f90 (working copy) @@ -1,4 +1,4 @@ -! { dg do-compile } +! { dg-do compile } ! Tests the fix for PR31630, in which the association of the argument ! of 'cmp' did not work. !